Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing currency information for Iceland and Bulgaria #2811

Merged
merged 2 commits into from
Aug 26, 2024
Merged

Add missing currency information for Iceland and Bulgaria #2811

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f2d0a5c
Add missing currency information for Iceland and Bulgaria
sponglord Aug 23, 2024
2f8b203
Adding changeset file
sponglord Aug 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/dirty-items-unite.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@adyen/adyen-web': patch
---

Adding missing currency information for Iceland and Bulgaria
1 change: 1 addition & 0 deletions packages/lib/src/utils/constants/currency-decimals.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ const CURRENCY_DECIMALS = {
GHC: 1,
GNF: 1,
KMF: 1,
ISK: 1,
Copy link

@jureperak jureperak Oct 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, are you sure that ISK needs to be set as zero decimal currency? In docs it clearly states that even do ISK is zero decimal, it will be used with two decimals https://docs.adyen.com/development-resources/currency-codes/#note

I'm asking this because, after this version, when i'm using dropin with CustomPay button, amount that i provide in ApplePay configuration for ISK is not same as in the version before this release. I will try to make a test on my sandbox environment and create an issue, but if you could verify this before me, even better.

PYG: 1,
RWF: 1,
UGX: 1,
Expand Down
2 changes: 2 additions & 0 deletions packages/lib/storybook/utils/get-currency.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
const currencies: Record<string, string> = {
AR: 'ARS',
AU: 'AUD',
BG: 'BGN',
BR: 'BRL',
CA: 'CAD',
CH: 'CHF',
Expand All @@ -13,6 +14,7 @@ const currencies: Record<string, string> = {
HU: 'HUN',
ID: 'IDR',
IN: 'INR',
IS: 'ISK',
JP: 'JPY',
KR: 'KRW',
MG: 'MGA',
Expand Down
Loading