Add missing currency information for Iceland and Bulgaria #2811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sponglord
requested review from
marcperez,
pabloai,
m1aw,
ribeiroguilherme and
longyulongyu
as code owners
🦋 Changeset detectedLatest commit: 2f8b203 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
|
Size Change: +14 B (0%) Total Size: 742 kB
ℹ️ View Unchanged
|
m1aw
approved these changes
Aug 23, 2024
Merged
|
jureperak
reviewed
Oct 23, 2024
| @@ -10,6 +10,7 @@ const CURRENCY_DECIMALS = { | |||
| GHC: 1, | |||
| GNF: 1, | |||
| KMF: 1, | |||
| ISK: 1, | |||
There was a problem hiding this comment.
Hey, are you sure that ISK needs to be set as zero decimal currency? In docs it clearly states that even do ISK is zero decimal, it will be used with two decimals https://docs.adyen.com/development-resources/currency-codes/#note
I'm asking this because, after this version, when i'm using dropin with CustomPay button, amount that i provide in ApplePay configuration for ISK is not same as in the version before this release. I will try to make a test on my sandbox environment and create an issue, but if you could verify this before me, even better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In v6 we added new locales: Iceland and Bulgaria.
This PR also adds the necessary currency information for these two, non-Euro, countries
Tested scenarios
Manually tested in Chrome, Firefox & Safari that currency is identified and formatted