[v6]Cherry pick new upi flow #2733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
longyulongyu
force-pushed
the
cherry-pick-new-upi-flow
branch
2 times, most recently
from
ae8eae6 to
2cda97d
Compare
* Add translations * refactor: more tests for onChange * refactor: await component supports shouldRedirectAutomatically, use await for the upi intent apps instead of redirect * refactor(upi-app-list): disable selection on loading * fix logo path * remove app list for upi story (cherry picked from commit 080f15b)
longyulongyu
force-pushed
the
cherry-pick-new-upi-flow
branch
from
2cda97d to
5e924ca
Compare
|
Size Change: +6.01 kB (+0.82%) Total Size: 735 kB
ℹ️ View Unchanged
|
size-limit report 📦
|
longyulongyu
requested review from
marcperez,
pabloai,
sponglord,
m1aw and
ribeiroguilherme
as code owners
longyulongyu
force-pushed
the
cherry-pick-new-upi-flow
branch
from
5e924ca to
75cbd3f
Compare
ribeiroguilherme
approved these changes
Jul 18, 2024
| paymentMethodsConfiguration, | ||
| paymentMethod.isStoredPaymentMethod | ||
| ); | ||
| const isStoredPaymentMethod = 'isStoredPaymentMethod' in paymentMethod && paymentMethod.isStoredPaymentMethod; |
There was a problem hiding this comment.
Is it needed to perform this check here? Just wondering that since it wasn't here before
There was a problem hiding this comment.
I got a TS error TS2339: Property isStoredPaymentMethod does not exist on type PaymentMethod | StoredPaymentMethod Property isStoredPaymentMethod does not exist on type PaymentMethod so I added this extra check.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary