[v6] Feature Enter key presses trigger validation #2704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…terKeyDown, for CustomCard
sponglord
requested review from
marcperez,
pabloai,
m1aw,
ribeiroguilherme and
longyulongyu
as code owners
|
|
Size Change: +2.39 kB (+0.33%) Total Size: 729 kB
ℹ️ View Unchanged
|
…for this handler first, then if not present activates the Pay Button
size-limit report 📦
|
…ccess component's payButton
…nt default behaviour, if the activeElement is a PMList header
…_validation' into feature/enterKey_presses_trigger_validation
ribeiroguilherme
approved these changes
Jun 27, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds new functionality to Components - the ability to submit the PM by pressing the Enter key.
Upon the shopper pressing the Enter key, we first look for the presence of an
onEnterKeyPressedcallback (defined atCheckoutconfig level), and if this is not defined, we trigger validation/submission of the PM form.If an
onEnterKeyPressedcallback is defined - it gets passed an object containing a reference to the PM component (UIElement) ; and a reference to the active element (document.activeElement) from which the "Enter" key press was triggeredTested scenarios
Tested:
New unit tests added
Relates to issue: COWEB-1181, #1881, #1242