Fix/detect in iframe fix #2475
Merged
Fix/detect in iframe fix #2475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sponglord
requested review from
marcperez,
pabloai,
m1aw,
ribeiroguilherme and
longyulongyu
as code owners
🦋 Changeset detectedLatest commit: 620ffe3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Size Change: +813 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
longyulongyu
reviewed
Dec 4, 2023
|
Kudos, SonarCloud Quality Gate passed! |
longyulongyu
approved these changes
Dec 6, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changing function name & functionality to more accurately reflect what this function is for - namely detecting if the sdk is running in an iframe inside an environment in which we can influence the location of the top window, if we need to.
Because what we need to know is if the page is being run in an iframe with the same origin as the parent- since this is the condition necessary to allow us to perform the redirect on the top level, parent, window rather than on the iframe's window.
If the iframe does not have the same origin as the parent there's no way we can send the top level window anywhere (the browser prevents access)
Tested scenarios
Fixed issue: