Fix/v6 improved integration warning #2467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e not been imported
sponglord
requested review from
marcperez,
pabloai,
m1aw,
ribeiroguilherme and
longyulongyu
as code owners
|
|
Size Change: +3.07 kB (0%) Total Size: 1.09 MB
ℹ️ View Unchanged
|
size-limit report 📦
|
ribeiroguilherme
approved these changes
Nov 27, 2023
There was a problem hiding this comment.
I believe that we can delete the core.registry warning and the supportedTxVariables variable from it. Then we keep only the Drop-in warning.
If I am not mistaken, the reason that the core.registry had its own console.warn is because previously the idea was to perform the component registration even with standalone component, and we also initially started the POC with using create function. Ex:
const checkout = await AdyenCheckout({
components: [Card],
...
});
checkout.create('card')..The code above would trigger a console.warn from the core.registry.
As the standalone components auto-register by itself now , it seems like we just need this warning for Drop-in
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Created a more informative warning for when Dropin detects that not all the supported PMs have been imported. The warning matches
txVariantsto the actual Class that will be required e.g.Tested scenarios
Warnings given for "non-imported" PM classes