Feature: Adds onAddressSelected to address lookup functionality #2406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 36846bb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Size Change: +19.3 kB (+2%) Total Size: 1.1 MB
|
m1aw
requested review from
marcperez,
pabloai,
sponglord,
ribeiroguilherme and
longyulongyu
as code owners
m1aw
changed the title
moaead
suggested changes
Nov 9, 2023
packages/lib/src/components/internal/Address/components/AddressSearch.tsx
Outdated
Show resolved
Hide resolved
packages/lib/src/components/internal/Address/components/AddressSearch.tsx
Outdated
Show resolved
Hide resolved
packages/lib/src/components/internal/Address/components/AddressSearch.tsx
Outdated
Show resolved
Hide resolved
packages/lib/src/components/internal/Address/components/AddressSearch.tsx
Show resolved
Hide resolved
ribeiroguilherme
approved these changes
Dec 4, 2023
| <Select | ||
| name={'address-search'} | ||
| className={'adyen-checkout__address-search__dropdown'} | ||
| //placeholder={i18n.get('address.placeholder')} |
There was a problem hiding this comment.
Can this comment be removed?
Merged
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The objective of this PR is to add
onAddressSelectedcallback. This callback works to provide a point of integration with Address completion services that require a second callback to access additional information, such is the case of Google Place Autocomplete API.Tested scenarios
Fixed issue: