feat: clean up

Adyen · Dec 1, 2023 · 76625a9 · 76625a9
1 parent 8336aa0
commit 76625a9
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 51 deletions.
diff --git a/packages/lib/src/components/CashAppPay/CashAppPay.tsx b/packages/lib/src/components/CashAppPay/CashAppPay.tsx
@@ -93,7 +93,7 @@ export class CashAppPay extends UIElement<CashAppPayConfiguration> {
         return this.props.storedPaymentMethodId ? 'Cash App Pay' : '';
     }
 
-    public submit = async () => {
+    public submit = () => {
         const { onClick, storedPaymentMethodId } = this.props;
 
         if (storedPaymentMethodId) {

diff --git a/packages/lib/src/components/Dropin/Dropin.tsx b/packages/lib/src/components/Dropin/Dropin.tsx
@@ -83,7 +83,7 @@ class DropinElement extends UIElement<DropinConfiguration> {
     /**
      * Calls the onSubmit event with the state of the activePaymentMethod
      */
-    public async submit(): Promise<void> {
+    public override submit(): void {
         if (!this.activePaymentMethod) {
             throw new Error('No active payment method.');
         }
@@ -122,8 +122,6 @@ class DropinElement extends UIElement<DropinConfiguration> {
     };
 
     public handleAction(action: PaymentAction, props = {}): this | null {
-        debugger;
-
         if (!action || !action.type) {
             if (hasOwnProperty(action, 'action') && hasOwnProperty(action, 'resultCode')) {
                 throw new Error(

diff --git a/packages/lib/src/components/PayPal/Paypal.tsx b/packages/lib/src/components/PayPal/Paypal.tsx
@@ -42,7 +42,7 @@ class PaypalElement extends UIElement<PayPalConfiguration> {
         };
     }
 
-    public submit = async () => {
+    public submit = () => {
         this.handleError(new AdyenCheckoutError('IMPLEMENTATION_ERROR', ERRORS.SUBMIT_NOT_SUPPORTED));
     };
 

diff --git a/packages/playground/src/pages/Dropin/manual.js b/packages/playground/src/pages/Dropin/manual.js
@@ -16,7 +16,6 @@ export async function initManual() {
 
         locale: 'pt-BR',
         translationFile: getTranslationFile(shopperLocale),
-        // translationFile: nl_NL,
 
         environment: process.env.__CLIENT_ENV__,
 
@@ -64,19 +63,6 @@ export async function initManual() {
             //
             //     return;
             // }
-            //
-            // if (result.resultCode === 'Authorised' || result.resultCode === 'Received') {
-            //     actions.resolve(result); // DO I NEED FULL RESULT?
-            // } else {
-            //     actions.reject(result);
-            // }
-
-            // return {
-            //     googlePayError: {
-            //         message: 'Not sufficient funds',
-            //             reason: 'OTHER_ERROR,'
-            //     }
-            // }
 
             //
             // // Trigger Error for GooglePay
@@ -93,38 +79,6 @@ export async function initManual() {
         onPaymentCompleted(result, element) {
             console.log('onPaymentCompleted', result, element);
         },
-        //
-        //
-        // // payments call
-        // if (result === AUTHORIZED)
-        //     return action.resolve({ orderTrackng: { /// details }})}
-        // }
-        //
-        //
-        // action.reject(new ApplePayError('')));
-
-        // // handle actions
-        // if (result.action) {
-        //     // demo only - store paymentData & order
-        //     if (result.action.paymentData) localStorage.setItem('storedPaymentData', result.action.paymentData);
-        //     component.handleAction(result.action, { challengeWindowSize: '01' });
-        // } else if (result.order && result.order?.remainingAmount?.value > 0) {
-        //     // handle orders
-        //     const order = {
-        //         orderData: result.order.orderData,
-        //         pspReference: result.order.pspReference
-        //     };
-        //
-        //     const orderPaymentMethods = await getPaymentMethods({ order, amount, shopperLocale });
-        //     checkout.update({ paymentMethodsResponse: orderPaymentMethods, order, amount: result.order.remainingAmount });
-        // } else {
-        //     handleFinalState(result.resultCode, component);
-        // }
-        // },
-        // srConfig: { showPanel: true },
-        // onChange: state => {
-        //     console.log('onChange', state);
-        // },
         onAdditionalDetails: async (state, component) => {
             const result = await makeDetailsCall(state.data);
-Original file line number
+Diff line change
@@ Expand Up / @@ -42,7 +42,7 @@ class PaypalElement extends UIElement<PayPalConfiguration> { @@
             };
         }
-        public submit = async () => {
+        public submit = () => {
             this.handleError(new AdyenCheckoutError('IMPLEMENTATION_ERROR', ERRORS.SUBMIT_NOT_SUPPORTED));
         };
@@ Expand Down @@