PayID tab UI elements #2012
PayID tab UI elements #2012
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
neelSharma12
requested review from
atmamont,
erenbesel,
nauaros and
goergisn
Adyen/UI/Form/Items/Value Pickers/Identifier Picker/FormAccountIdentifierPickerItem.swift
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| public var identifier: String { | ||
| switch self { |
There was a problem hiding this comment.
This is added in case we need different identifier from rawValue for api call.
There was a problem hiding this comment.
In this case rawValue can and should be identifier. What else is there to make this enum's elements unique? Nice catch!
| } | ||
|
|
||
| let item = FormStringPickerItem( | ||
| preselectedIdentifier: selectableValues[0], |
There was a problem hiding this comment.
if the selectableValues is nil?
There was a problem hiding this comment.
If the list is are empty accessing the first element will crash - ideally use selectableValues.first and try to unwrap the optional
| context: Dummy.context | ||
| ) | ||
|
|
||
| setupRootViewController(sut.viewController) |
There was a problem hiding this comment.
sut.viewController.loadIfNeeded()
|
|
||
| // MARK: - Private | ||
|
|
||
| private func contentView(formVC: FormViewController) { |
There was a problem hiding this comment.
What are these used for? The function name could be a bit more descriptive
There was a problem hiding this comment.
It is for constructing UI but I can rename it :)
Adyen/UI/Form/Items/Value Pickers/Identifier Picker/FormStringPickerItem.swift
Outdated
Show resolved
Hide resolved
✅ No changes detectedComparing Analyzed targets: Adyen, AdyenActions, AdyenCard, AdyenCashAppPay, AdyenComponents, AdyenDelegatedAuthentication, AdyenDropIn, AdyenEncryption, AdyenSession, AdyenSwiftUI, AdyenTwint, AdyenWeChatPay |
|
|
|
||
| // MARK: - Private | ||
|
|
||
| private func payIDContentView(formVC: FormViewController) { |
There was a problem hiding this comment.
The function still does not really say what it does - based on the name I'd assume it returns a contentView but it actually appends item to the form.
Maybe instead call it func appendNameInputItems(to formVC: FormViewController) or something similar to not have to go through the function implementation to figure out what it does.
Also if the function is only used once - it might be even ok to move the calls from the function body to the call site. So all the appending to the form happens in one place.
Summary
- Added Identifier picker UI. - Added First name input field. - Added last name input field.Ticket
COIOS-865