-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Warnings #1958
Fix Warnings #1958
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request does not contain a valid label. Please add one of the following labels: ['new', 'changed', 'fixed', 'removed', 'deprecated', 'chore', 'improvement']
602839d
✅ No changes detectedComparing Analyzed targets: Adyen, AdyenActions, AdyenCard, AdyenCashAppPay, AdyenComponents, AdyenDelegatedAuthentication, AdyenDropIn, AdyenEncryption, AdyenSession, AdyenSwiftUI, AdyenTwint, AdyenWeChatPay |
|
Closing due to quite some changes for very little benefit |
Summary
Background regarding #if compiler(>=6)
Xcode started complaining:
Issue
When adding the @retroactive tag it silences the warning but it will start failing if you build with a compiler that doesn’t know about this label. Which is the case on our CI because we need older Xcodes (with older toolchain) to get access to older Simulators to be able to test older iOS versions.
Solution
You can check for the swift or compiler version that is used to compile your project via a compiler directive.
e.g.
So wrapping the code in an
#if compiler(>=6)
block and providing the old code in the#else
block silences the warnings AND allows you to build the code with older toolchainsTicket
COIOS-000