Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analytics in apple pay component #1947

Merged
merged 2 commits into from
Jan 15, 2025
Merged

Analytics in apple pay component #1947

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f4fdcf
correctly track apple pay component
erenbesel Jan 15, 2025
8185ea7
use loadViewIfNeeded instead of setupRoot for SUT
erenbesel Jan 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions AdyenComponents/Apple Pay/ApplePayComponent.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,10 +78,12 @@ public class ApplePayComponent: NSObject, PresentableComponent, PaymentComponent
super.init()

paymentAuthorizationViewController?.delegate = self
sendInitialAnalytics()
}

public var viewController: UIViewController {
createPaymentAuthorizationViewController()
sendDidLoadEvent()
return createPaymentAuthorizationViewController()
}

public func didFinalize(with success: Bool, completion: (() -> Void)?) {
Expand Down Expand Up @@ -130,6 +132,3 @@ extension ApplePayComponent {

@_spi(AdyenInternal)
extension ApplePayComponent: TrackableComponent {}

@_spi(AdyenInternal)
extension ApplePayComponent: ViewControllerDelegate {}
2 changes: 1 addition & 1 deletion Tests/IntegrationTests/Components Tests/Apple Pay/ApplePayComponentTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -424,7 +424,7 @@ class ApplePayComponentTest: XCTestCase {
)

// When
sut.viewDidLoad(viewController: mockViewController)
setupRootViewController(sut.viewController)
erenbesel marked this conversation as resolved.
Show resolved Hide resolved

// Then
XCTAssertEqual(analyticsProviderMock.initialEventCallsCount, 1)
Expand Down
Loading