Analytics in apple pay component #1947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erenbesel
added
the
chore
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
atmamont
previously approved these changes
Jan 15, 2025
Tests/IntegrationTests/Components Tests/Apple Pay/ApplePayComponentTests.swift
Outdated
Show resolved
Hide resolved
nauaros
previously approved these changes
Jan 15, 2025
erenbesel
dismissed stale reviews from nauaros, atmamont, and github-actions[bot]
via
8185ea7
goergisn
approved these changes
Jan 15, 2025
✅ No changes detectedComparing Analyzed targets: Adyen, AdyenActions, AdyenCard, AdyenCashAppPay, AdyenComponents, AdyenDelegatedAuthentication, AdyenDropIn, AdyenEncryption, AdyenSession, AdyenSwiftUI, AdyenTwint, AdyenWeChatPay |
|
descorp
approved these changes
Jan 15, 2025
neelSharma12
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Generic analytics code via the
ViewControllerDelegateonTrackableComponentdoes not work onApplePayComponentas its view controller is not aFormViewController.Call analytics explicitly here and remove redundant conformance to
ViewControllerDelegateTicket
COIOS-849