[MVP] Switching to a swift command line tool #1718
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Scripts/public-api-diff/Sources/Helpers/FileHandling/FileHandling+Convenience.swift
Outdated
Show resolved
Hide resolved
| "Cartfile" | ||
| ] | ||
|
|
||
| let fileExtensionIgnoreList: Set<String> = [ |
There was a problem hiding this comment.
Couldn't these two sets be combined?
There was a problem hiding this comment.
Yeah, not too happy with these lists either - would have to replace it with a regex - I added a TODO to tackle in another PR
| let destinationFilePath = destinationDirectoryPath.appending("/\(fileName)") | ||
|
|
||
| // Using shell here as it's faster than the FileManager | ||
| shell.execute("cp -a \(sourceFilePath) \(destinationFilePath)") |
There was a problem hiding this comment.
Do we sanitize user input anywhere? I quickly scanned changes and didn't find it right away.
There was a problem hiding this comment.
No there is no explicit sanitization going on here but because of previous calls we know that the paths are valid file paths. Might want to revisit this decision though
goergisn
dismissed stale reviews from atmamont, nauaros, and github-actions[bot]
via
11b29b7
✅ No changes detectedComparing Analyzed modules: Adyen, AdyenActions, AdyenCard, AdyenCashAppPay, AdyenComponents, AdyenDelegatedAuthentication, AdyenDropIn, AdyenEncryption, AdyenSession, AdyenSwiftUI, AdyenTwint, AdyenWeChatPay |
|
Summary
Output
Without public changes
With public changes (Shortened for the sake of showcasing)
TODO for a future PR