Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Api change detection improvements #1717

Merged
merged 48 commits into from
Jun 19, 2024
Merged

Conversation

goergisn
Copy link
Contributor

@goergisn goergisn commented Jun 14, 2024

Summary

  • Modifies the Package.swift to contain all targets
  • Only builds the current project + comparison project once
  • Automatically considers all available targets (instead of hardcoding them)

@goergisn goergisn added the chore a pull request that has chore changes that shouldn't be in the release notes label Jun 14, 2024
github-actions[bot]
github-actions bot previously approved these changes Jun 14, 2024
github-actions[bot]
github-actions bot previously approved these changes Jun 14, 2024
github-actions[bot]
github-actions bot previously approved these changes Jun 15, 2024
@Adyen Adyen deleted a comment from github-actions bot Jun 17, 2024
@goergisn goergisn marked this pull request as ready for review June 19, 2024 07:40
atmamont
atmamont previously approved these changes Jun 19, 2024
Copy link
Contributor

@atmamont atmamont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niiice improvements! 👏
All my comments are basically nitpicks to make scaling phase easier.
Please decide yourself if you want to address it now.

descorp
descorp previously approved these changes Jun 19, 2024
@goergisn goergisn dismissed stale reviews from descorp, github-actions[bot], and atmamont via a323386 June 19, 2024 12:40
@goergisn goergisn merged commit 7094702 into develop Jun 19, 2024
7 of 10 checks passed
@goergisn goergisn deleted the api_change_detection_improvements branch June 19, 2024 12:40
Copy link
Contributor

Public API Changes

🫧 Adyen - No changes detected

🫧 AdyenActions - No changes detected

🫧 AdyenCard - No changes detected

🫧 AdyenCashAppPay - No changes detected

🫧 AdyenComponents - No changes detected

🫧 AdyenDelegatedAuthentication - No changes detected

🫧 AdyenDropIn - No changes detected

🫧 AdyenEncryption - No changes detected

🫧 AdyenSession - No changes detected

🫧 AdyenSwiftUI - No changes detected

🫧 AdyenTwint - No changes detected

🫧 AdyenWeChatPay - No changes detected

🫧 TwintSDK - No changes detected

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore a pull request that has chore changes that shouldn't be in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants