New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect public api changes #1708

Merged

goergisn merged 36 commits into develop from api_change_detection

Jun 14, 2024

Contributor

goergisn commented Jun 6, 2024 •

edited

Loading

Summary

Adds a github action to detect public api changes

Possible improvements

Show a status/emoji that quickly represents whether or not there are actual changes
(Speed) Optimization (See TODOs)


          Adding scripts to detect api changes

752515e

goergisn changed the title ~~Adding scripts to detect api changes~~ Detect public api changes

goergisn added the chore label

github-actions bot previously approved these changes

View reviewed changes


          changing github action

5787fb8

goergisn dismissed github-actions[bot]’s stale review via

5787fb8

June 6, 2024 14:27

github-actions bot previously approved these changes

View reviewed changes


          adjusted script

b3b3765

goergisn dismissed github-actions[bot]’s stale review via

b3b3765

June 6, 2024 14:34

github-actions bot previously approved these changes

View reviewed changes


          More changes

ffebcc2

goergisn dismissed github-actions[bot]’s stale review via

ffebcc2

June 6, 2024 14:36

github-actions bot previously approved these changes

View reviewed changes


          fixing script

3cadff7

goergisn dismissed github-actions[bot]’s stale review via

3cadff7

June 6, 2024 14:40

github-actions bot previously approved these changes

View reviewed changes

goergisn changed the base branch from develop to main

June 6, 2024 14:46

goergisn dismissed github-actions[bot]’s stale review

June 6, 2024 14:46

The base branch was changed.

goergisn changed the base branch from main to remove-pay-button-research

June 6, 2024 14:47

goergisn changed the base branch from remove-pay-button-research to main

June 6, 2024 14:47

github-actions bot previously approved these changes

View reviewed changes


          small sanitation

d2cf211

goergisn dismissed github-actions[bot]’s stale review via

d2cf211

June 6, 2024 14:49

github-actions bot previously approved these changes

View reviewed changes


          Remove diffing

a8598f1

goergisn dismissed github-actions[bot]’s stale review via

a8598f1

June 6, 2024 14:56

github-actions bot previously approved these changes

View reviewed changes


          adding module name

f4f7754

goergisn dismissed github-actions[bot]’s stale review via

f4f7754

June 7, 2024 09:34

github-actions bot previously approved these changes

View reviewed changes

github-actions bot previously approved these changes

View reviewed changes

goergisn requested review from erenbesel, nauaros and atmamont

June 13, 2024 08:29

nauaros reviewed

View reviewed changes

Scripts/compare_public_interface_definition.swift Show resolved Hide resolved

nauaros reviewed

View reviewed changes

Scripts/compare_public_interface_definition.swift Outdated Show resolved Hide resolved

nauaros previously approved these changes

View reviewed changes


          extracting find function to Element extension

c62c607

goergisn dismissed stale reviews from nauaros and github-actions[bot] via

c62c607

June 13, 2024 09:37

goergisn requested a review from nauaros

June 13, 2024 09:38

github-actions bot previously approved these changes

View reviewed changes

nauaros previously approved these changes

View reviewed changes

atmamont reviewed

View reviewed changes

Scripts/generate_public_interface_definition.sh Outdated Show resolved Hide resolved

atmamont previously approved these changes

View reviewed changes

Contributor

atmamont left a comment

👏 This will be truly helpful!


          Adding documentation

9fd987f

goergisn dismissed stale reviews from atmamont, nauaros, and github-actions[bot] via

9fd987f

June 13, 2024 14:45

github-actions bot previously approved these changes

View reviewed changes


          Remove scripts folder from spell check

afe29a7

goergisn dismissed github-actions[bot]’s stale review via

afe29a7

June 13, 2024 14:48

github-actions bot approved these changes

View reviewed changes

goergisn requested review from atmamont and nauaros

June 13, 2024 14:49

Contributor

github-actions bot commented Jun 13, 2024

Public API Changes

🫧 `Adyen`

No changes detected

🫧 `AdyenDropIn`

No changes detected

🫧 `AdyenActions`

No changes detected

🫧 `AdyenCard`

No changes detected

🫧 `AdyenEncryption`

No changes detected

🫧 `AdyenComponents`

No changes detected

🫧 `AdyenSession`

No changes detected

🫧 `AdyenWeChatPay`

No changes detected

🫧 `AdyenCashAppPay`

No changes detected

🫧 `AdyenTwint`

No changes detected

🫧 `AdyenDelegatedAuthentication`

No changes detected

sonarqubecloud bot commented Jun 13, 2024

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

atmamont approved these changes

View reviewed changes

goergisn merged commit f5d8ce6 into develop

12 checks passed

goergisn deleted the api_change_detection branch

June 14, 2024 13:06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore