Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AD-297 Rework AdyenSubscription Extension to Align with New Architecture #462

Merged
merged 3 commits into from
Oct 30, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions adyenv6subscription/resources/adyenv6subscription-spring.xml
Original file line number Diff line number Diff line change
Expand Up @@ -10,17 +10,6 @@

http://www.springframework.org/schema/util http://www.springframework.org/schema/util/spring-util.xsd">

<alias name="subscriptionAdyenPaymentServiceFactory" alias="adyenPaymentServiceFactory" />
<bean id="subscriptionAdyenPaymentServiceFactory" class="com.adyen.v6.factory.SubscriptionAdyenPaymentServiceFactory">
<constructor-arg name="adyenRequestFactory" ref="adyenRequestFactory"/>
<constructor-arg name="adyenMerchantAccountStrategy" ref="adyenMerchantStrategy"/>
</bean>

<alias name="subscriptionRequestFactory" alias="adyenRequestFactory" />
<bean id="subscriptionRequestFactory" class="com.adyen.v6.factory.SubscriptionPaymentRequestFactory">
<property name="cartFacade" ref="cartFacade" />
</bean>

<bean id="subscriptionRepository" class="com.adyen.v6.repository.SubscriptionRepository" >
<property name="flexibleSearchService" ref="flexibleSearchService" />
</bean>
Expand All @@ -36,7 +25,6 @@
<property name="baseStoreService" ref="baseStoreService" />
<property name="modelService" ref="modelService" />
<property name="keyGenerator" ref="orderCodeGenerator" />
<property name="subscriptionAdyenPaymentServiceFactory" ref="subscriptionAdyenPaymentServiceFactory" />
</bean>

<alias alias="subscriptionCommercePlaceOrderMethodHook" name="adyenSubscriptionCommercePlaceOrderMethodHook"/>
Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

import com.adyen.model.checkout.PaymentResponse;
import com.adyen.v6.factory.AdyenPaymentServiceFactory;
import com.adyen.v6.factory.SubscriptionAdyenPaymentServiceFactory;
import com.adyen.v6.model.RequestInfo;
import com.adyen.v6.service.AdyenTransactionService;
import de.hybris.platform.commercefacades.order.data.CartData;
Expand Down Expand Up @@ -42,8 +41,6 @@ public class SubscriptionOrderExecutor implements ImpersonationService.Executor<
private KeyGenerator keyGenerator;
private final AbstractOrderModel subscriptionOrder;

private SubscriptionAdyenPaymentServiceFactory subscriptionAdyenPaymentServiceFactory;

public SubscriptionOrderExecutor(final AbstractOrderModel subscriptionOrder)
{
this.subscriptionOrder = subscriptionOrder;
Expand All @@ -58,7 +55,7 @@ public OrderModel execute() throws Exception {
try {

final RequestInfo request = new RequestInfo();
final PaymentResponse paymentResponse = subscriptionAdyenPaymentServiceFactory
final PaymentResponse paymentResponse = adyenPaymentServiceFactory
.createAdyenCheckoutApiService(baseStoreService.getCurrentBaseStore())
.authorisePayment(cartConverter.convert(cart), request, (CustomerModel) cart.getUser());

Expand Down Expand Up @@ -159,7 +156,4 @@ public void setKeyGenerator(KeyGenerator keyGenerator) {
this.keyGenerator = keyGenerator;
}

public void setSubscriptionAdyenPaymentServiceFactory(SubscriptionAdyenPaymentServiceFactory subscriptionAdyenPaymentServiceFactory) {
this.subscriptionAdyenPaymentServiceFactory = subscriptionAdyenPaymentServiceFactory;
}
}

This file was deleted.