Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating model for Refund Fail webhook and small improvements #52

Merged
merged 3 commits into from
Jul 11, 2024
Merged

Updating model for Refund Fail webhook and small improvements #52

merged 3 commits into from
Jul 11, 2024

Conversation

dcardos
Copy link
Contributor

@dcardos dcardos commented Jul 8, 2024 •
edited
Loading

Summary

Describe the changes proposed in this pull request:

  • What is the motivation for this change?
    So next release of OMS can log refund_fail webhook, given merchant visibility of when this happens in SF.

Additionally

  • removing deprecated and unused paymentPspReference variable from NotificationRequestItem
  • converting string to integer for http server error code
  • small refactoring of HMAC class to fix lint issues

@dcardos dcardos requested a review from shubhamk67 July 8, 2024 14:34
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@dcardos dcardos merged commit 45a3ba0 into develop Jul 11, 2024
2 checks passed
@dcardos dcardos deleted the task/SFI-642-update-model branch July 11, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zenit2001 zenit2001 zenit2001 approved these changes

@shubhamk67 shubhamk67 shubhamk67 approved these changes

@amihajlovski amihajlovski Awaiting requested review from amihajlovski amihajlovski is a code owner

@shanikantsingh shanikantsingh Awaiting requested review from shanikantsingh shanikantsingh is a code owner

@ShubhamVijaivargiya ShubhamVijaivargiya Awaiting requested review from ShubhamVijaivargiya ShubhamVijaivargiya is a code owner

Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dcardos @zenit2001 @shubhamk67