Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 5.8.0 #1925

Merged
merged 157 commits into from
Dec 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
157 commits
Select commit Hold shift + click to select a range
06e040c
Merge pull request #1829 from Adyen/main
ozgur00 Oct 15, 2024
0d80706
Create libs.versions.toml and migrate dependencies to it
jreij Sep 5, 2024
12ceb08
Merge pull request #1784 from Adyen/chore/migrate-to-version-catalogs
jreij Oct 15, 2024
df3f8e4
Explicitly declare compose compiler in libraries in libs.versions.toml
jreij Oct 15, 2024
c31286e
Merge pull request #1831 from Adyen/chore/compose-complier-renovate-fix
jreij Oct 15, 2024
c107a46
Update Kotlin
renovate[bot] Oct 15, 2024
fd74304
Merge pull request #1771 from Adyen/renovate/kotlin
jreij Oct 15, 2024
01804c6
Update dependency gradle to v8.10.2
renovate[bot] Oct 15, 2024
cd96e65
Merge pull request #1779 from Adyen/renovate/gradle-8.x
jreij Oct 15, 2024
15808bb
Uncomment 3DS2 tests that were previously failing because of obfuscation
jreij Oct 15, 2024
e0f706e
Update 3DS2 SDK to version 2.2.21
jreij Oct 15, 2024
d1e088e
Merge pull request #1833 from Adyen/chore/3ds2-tests
jreij Oct 16, 2024
79fcf1e
Update JamesIves/github-pages-deploy-action action to v4.6.8
renovate[bot] Oct 16, 2024
97813e6
Merge pull request #1834 from Adyen/renovate/jamesives-github-pages-d…
jreij Oct 16, 2024
b9ade0c
Update dependency androidx.annotation:annotation to v1.8.2
renovate[bot] Oct 16, 2024
9ab5493
Merge pull request #1835 from Adyen/renovate/annotation
jreij Oct 16, 2024
60fccca
Update dependency androidx.fragment:fragment-ktx to v1.8.4
renovate[bot] Oct 16, 2024
54119a8
Merge pull request #1836 from Adyen/renovate/fragment
jreij Oct 16, 2024
04301da
Update android.gradle.plugin to v8.7.1
renovate[bot] Oct 16, 2024
6bba6f4
Update verification metadata
jreij Oct 16, 2024
8495a52
Merge pull request #1837 from Adyen/renovate/android.gradle.plugin
jreij Oct 16, 2024
c2cd1b5
Fix reading BuildConfig.CHECKOUT_VERSION from toml file
jreij Oct 16, 2024
2ddaba5
Merge pull request #1840 from Adyen/chore/fix-checkout-version-build-…
jreij Oct 16, 2024
913cdfa
Replace prefill with autofill for test cards app in readme
jreij Oct 17, 2024
5b72818
Merge pull request #1841 from Adyen/chore/fix-readme-autofill
jreij Oct 17, 2024
59a3f54
Update the script to retrieve the version-name from version catalogs …
araratthehero Oct 23, 2024
8b9f809
Merge pull request #1848 from Adyen/chore/fix-reading-version-name-sc…
araratthehero Oct 23, 2024
b703418
Introduce DispatcherProvider
ozgur00 Oct 18, 2024
c45a6ee
Merge pull request #1842 from Adyen/chore/dispatcher-provider
ozgur00 Oct 25, 2024
f99a25c
Add lint rule to prevent the use of JSONObject's optString, optBoolea…
jreij Oct 8, 2024
feeffe5
Replace JSONObject's opt functions with nullable extensions
jreij Oct 8, 2024
578cb23
Merge pull request #1815 from Adyen/chore/json-opt-functions
jreij Oct 28, 2024
4ac905a
Update junit5 monorepo to v5.11.3
renovate[bot] Oct 28, 2024
f2d1b4f
Merge pull request #1838 from Adyen/renovate/junit5-monorepo
araratthehero Oct 28, 2024
84022a8
Update dependency org.sonarqube to v5.1.0.4882
renovate[bot] Oct 28, 2024
036226b
Merge pull request #1839 from Adyen/renovate/sonarqube
araratthehero Oct 28, 2024
a4e7e7a
Replace usage of Dispatchers with DispatcherProvider
OscarSpruit Oct 28, 2024
abda40d
Merge pull request #1851 from Adyen/chore/fix-dispatchers-in-example
OscarSpruit Oct 29, 2024
d21c072
Create Error event type in analytics
araratthehero Oct 15, 2024
ea7bd39
Add error event support to Analytics manager
araratthehero Oct 15, 2024
8f82398
Simplify the check before sending events
araratthehero Oct 30, 2024
ec1db9b
Merge pull request #1830 from Adyen/feature/analytics_error_events_base
araratthehero Oct 31, 2024
d1dc995
Update lint to v31.7.1
renovate[bot] Nov 1, 2024
c43bd77
Merge pull request #1862 from Adyen/renovate/lint
OscarSpruit Nov 1, 2024
44d6086
Update mockito monorepo to v5.14.2
renovate[bot] Nov 1, 2024
6ba2fe2
Merge pull request #1867 from Adyen/renovate/mockito-monorepo
jreij Nov 1, 2024
d6d6a31
Update dependency app.cash.turbine:turbine to v1.2.0
renovate[bot] Nov 1, 2024
db583e6
Merge pull request #1866 from Adyen/renovate/turbine
jreij Nov 1, 2024
0aeab40
Update dependency androidx.compose:compose-bom to v2024.10.00
renovate[bot] Nov 1, 2024
bcc090f
Merge pull request #1864 from Adyen/renovate/compose.bom
jreij Nov 1, 2024
4e2f9bc
Update gradle/actions action to v4
renovate[bot] Nov 1, 2024
e428988
Merge pull request #1869 from Adyen/renovate/gradle-actions-4.x
jreij Nov 1, 2024
7134436
Update dependency androidx.annotation:annotation to v1.9.0
renovate[bot] Nov 1, 2024
bdcf2fb
Merge pull request #1863 from Adyen/renovate/annotation
jreij Nov 1, 2024
32cc466
Update dependency androidx.activity:activity to v1.9.3
renovate[bot] Nov 1, 2024
f908c0a
Merge pull request #1857 from Adyen/renovate/activity
araratthehero Nov 1, 2024
f00fad4
Update dependency androidx.activity:activity-compose to v1.9.3
renovate[bot] Nov 1, 2024
f48215b
Merge pull request #1858 from Adyen/renovate/compose.activity
araratthehero Nov 1, 2024
367f738
Update lifecycle to v2.8.6
renovate[bot] Nov 1, 2024
31a1634
Merge pull request #1861 from Adyen/renovate/lifecycle
jreij Nov 1, 2024
3076e6f
Update dependency androidx.autofill:autofill to v1.3.0-beta01
renovate[bot] Nov 1, 2024
31b4088
Merge pull request #1859 from Adyen/renovate/autofill
OscarSpruit Nov 4, 2024
4d87139
Update dependency androidx.lifecycle:lifecycle-viewmodel-compose to v…
renovate[bot] Nov 4, 2024
74c424d
Merge pull request #1860 from Adyen/renovate/compose.viewmodel
jreij Nov 4, 2024
d40b18d
Update thollander/actions-comment-pull-request action to v3
renovate[bot] Nov 4, 2024
00fb705
Fix breaking changes caused by v3 migration
jreij Nov 4, 2024
a44d0ef
Merge pull request #1870 from Adyen/renovate/thollander-actions-comme…
jreij Nov 4, 2024
37bd155
Track Closed Log event for Drop-in
araratthehero Nov 5, 2024
4915c2f
Move rendered event for Drop-in to DropInEvents
araratthehero Nov 5, 2024
00288d5
Merge pull request #1876 from Adyen/feature/analytics_track_event_whe…
araratthehero Nov 5, 2024
c55bdf4
Fix address lookup data not being correctly saved in payment componen…
ozgur00 Nov 7, 2024
66e7e22
Merge pull request #1879 from Adyen/fix/address-lookup
ozgur00 Nov 8, 2024
53ae693
Track encryption related errors
ozgur00 Nov 7, 2024
f8cacda
Remove suppress annotation from GenericEvents.error function
ozgur00 Nov 7, 2024
02d8fb4
Add tests for tracking encryption analytics events
ozgur00 Nov 7, 2024
deda680
Merge pull request #1881 from Adyen/feature/analytics_encryption_error
ozgur00 Nov 8, 2024
797f650
Remove incorrect Singleton annotation in AddressLookupRepository
jreij Nov 8, 2024
52b1778
Remove state flow from AddressLookupRepository to make sure onAddress…
jreij Nov 8, 2024
e4e2138
Remove onLookupCompletion override in CardActivity to allow testing t…
jreij Nov 8, 2024
2936475
Merge pull request #1886 from Adyen/chore/address-example-app-fixes
jreij Nov 11, 2024
433048e
Fix address lookup view not retaining correct input state
ozgur00 Nov 8, 2024
fddfade
Fix address lookup view not retaining correct input state
ozgur00 Nov 8, 2024
ec4cd7d
Merge pull request #1885 from Adyen/fix/address-lookup-input-data
ozgur00 Nov 11, 2024
de4b411
Update release notes
ozgur00 Nov 12, 2024
dbc26ca
Merge pull request #1890 from Adyen/chore/release-notes
ozgur00 Nov 12, 2024
5b4f3f2
Bump version to 5.7.1
jreij Nov 13, 2024
2adfd4d
Merge pull request #1891 from Adyen/chore/bump-version-5-7-1
jreij Nov 13, 2024
deedfaf
Add lint rule that prevents Dispatchers usage
OscarSpruit Nov 11, 2024
454a597
Suppress NotDispatcherProvider rule in DispatcherProvider
OscarSpruit Nov 13, 2024
357cf03
Merge pull request #1888 from Adyen/chore/dispatchers-lint-rule
OscarSpruit Nov 14, 2024
f6748f3
Centralize IO dispatcher usage in example app
OscarSpruit Nov 14, 2024
80d8585
Merge pull request #1893 from Adyen/chore/centralize-dispatcher-provider
OscarSpruit Nov 15, 2024
45f0176
Rename analytics param level from None to Initial
araratthehero Oct 30, 2024
ed3a0bf
Fix read parcelable classLoader type
araratthehero Oct 30, 2024
103e987
Send level as part of the initial analytics request
araratthehero Oct 31, 2024
a0123c6
Merge pull request #1856 from Adyen/feature/analytics_level_field
araratthehero Nov 19, 2024
88f6972
Add target to error events
araratthehero Nov 7, 2024
7b9fe18
Track redirect failed event
araratthehero Nov 7, 2024
0b7532c
Track redirect parse failed event
araratthehero Nov 7, 2024
692e058
Track redirect cancelled event
araratthehero Nov 7, 2024
091f501
Merge pull request #1882 from Adyen/feature/analytics_track_redirect_…
araratthehero Nov 19, 2024
608f48c
Fix NPE when pressing back and postal code is focussed in address lookup
OscarSpruit Nov 19, 2024
6a22388
Add release note
OscarSpruit Nov 19, 2024
c60a98f
Merge pull request #1894 from Adyen/fix/address-lookup-back-press
OscarSpruit Nov 26, 2024
a92213f
Immediately add the loading dialog to the fragment manager
OscarSpruit Nov 19, 2024
036ce79
Remove unused progress spinner in gift card bottom sheet
OscarSpruit Nov 19, 2024
6d2c779
Make sure loading state is dismissed before handling result
OscarSpruit Nov 19, 2024
3a70336
Add release note
OscarSpruit Nov 20, 2024
444305c
Merge pull request #1895 from Adyen/fix/loading-state-overlapping-error
OscarSpruit Nov 27, 2024
6e3c00b
Remove tracking redirect error event when user closes redirect
araratthehero Nov 26, 2024
9a85e78
Merge pull request #1901 from Adyen/feature/analytics_track_redirect_…
araratthehero Nov 27, 2024
805d5fa
Track third party error event for Twint
araratthehero Nov 11, 2024
4b2ad0a
Track third party error event for WeChat
araratthehero Nov 11, 2024
341adfd
Track third party error event for CashAppPay
araratthehero Nov 11, 2024
a9e34b5
Track third party error event for Google Pay
araratthehero Nov 20, 2024
81c2842
Merge pull request #1887 from Adyen/feature/analytics_track_third_par…
araratthehero Nov 28, 2024
9f24864
Update dependency com.pinterest.ktlint:ktlint-cli to v1.4.1
renovate[bot] Dec 1, 2024
9efa935
Merge pull request #1918 from Adyen/renovate/ktlint
jreij Dec 2, 2024
062b6d7
Update lint to v31.7.2
renovate[bot] Dec 2, 2024
78f494c
Merge pull request #1915 from Adyen/renovate/lint
jreij Dec 2, 2024
08a6529
Update JamesIves/github-pages-deploy-action action to v4.6.9
renovate[bot] Dec 2, 2024
bf5e220
Merge pull request #1909 from Adyen/renovate/jamesives-github-pages-d…
araratthehero Dec 2, 2024
efd0746
Update dependency androidx.annotation:annotation to v1.9.1
renovate[bot] Dec 3, 2024
5ad2c32
Merge pull request #1911 from Adyen/renovate/annotation
araratthehero Dec 3, 2024
e4b0079
Update dependency androidx.fragment:fragment-ktx to v1.8.5
renovate[bot] Dec 3, 2024
cb5758e
Merge pull request #1912 from Adyen/renovate/fragment
araratthehero Dec 3, 2024
33439dc
Create paybybank-us module
ozgur00 Oct 21, 2024
0bd9e3d
Create paybybank-us component files
ozgur00 Oct 21, 2024
9d512ce
Implement PayByBankUSConfiguration
ozgur00 Oct 21, 2024
00a3443
Add PayByBankUSConfigurationTest
ozgur00 Oct 24, 2024
3e75f74
Implement paybybank-us component, delegate and component state classes
ozgur00 Oct 25, 2024
7fca1df
Implement PayByBankUSComponentProvider
ozgur00 Nov 1, 2024
be47252
Implement PayByBankUSComponent
ozgur00 Nov 1, 2024
ab1518c
Implement DefaultPayByBankUSDelegate
ozgur00 Nov 1, 2024
3bc8c1e
Implement ui for PayByBankUSComponent
ozgur00 Nov 1, 2024
638f9b1
Include paybybank-us module in drop-in
ozgur00 Nov 4, 2024
978e98d
Display brand logos on PayByBankUS item in payment methods list
ozgur00 Nov 4, 2024
759504d
Add PayByBankUSComponentTest
ozgur00 Nov 5, 2024
0d3a893
Add DefaultPayByBankUSDelegateTest
ozgur00 Nov 5, 2024
d1b2871
Display 4 logos on drop-in payment methods list for Pay by Bank US
ozgur00 Nov 12, 2024
79a5aaf
Add release notes for PayByBankUSComponent
ozgur00 Nov 26, 2024
7830bca
Add Pay by Bank US to supported payment method types
ozgur00 Nov 27, 2024
024ee01
Add StoredPayByBankUSDelegate
ozgur00 Nov 26, 2024
ec9e6ed
Add display logic for Pay by Bank US using label in stored payment me…
ozgur00 Nov 27, 2024
fcaba3a
Initialize analytics in StoredPayByBankUSDelegate
ozgur00 Nov 28, 2024
cebe3f7
Add StoredPayByBankUSDelegateTest
ozgur00 Nov 28, 2024
5534bf7
Remove unnecessary dependencies from StoredPayByBankUSDelegate
ozgur00 Nov 29, 2024
77f9a41
Display Pay by Bank account name in stored payment confirmation pop-up
ozgur00 Nov 29, 2024
174f52c
Display confirmation popup before triggering payment in PreselectedSt…
ozgur00 Nov 29, 2024
6c5c8da
Remove unnecessary suppress annotation in PayByBankUSComponent
ozgur00 Dec 2, 2024
7d25d47
Merge pull request #1899 from Adyen/feature/pay-by-bank-us
ozgur00 Dec 3, 2024
777378f
Mark release as draft in publish release job
jreij Dec 4, 2024
4ef4c75
Merge pull request #1922 from Adyen/chore/release-as-draft
jreij Dec 4, 2024
d9a805f
Make sure the loading fragment transaction is completed before trying…
OscarSpruit Dec 4, 2024
6e4a0b9
Merge pull request #1924 from Adyen/fix/opening-instant-pms
OscarSpruit Dec 5, 2024
582b9ba
Prepare release 5.8.0
ozgur00 Dec 3, 2024
71d88ce
Merge pull request #1920 from Adyen/release/5.8.0
ozgur00 Dec 5, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
2 changes: 1 addition & 1 deletion .github/workflows/assemble.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
java-version: 17

- name: Gradle cache
uses: gradle/actions/setup-gradle@v3
uses: gradle/actions/setup-gradle@v4
with:
cache-read-only: false

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/check_release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
java-version: 17

- name: Gradle cache
uses: gradle/actions/setup-gradle@v3
uses: gradle/actions/setup-gradle@v4
with:
cache-read-only: true

Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/code_analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
java-version: 17

- name: Gradle cache
uses: gradle/actions/setup-gradle@v3
uses: gradle/actions/setup-gradle@v4
with:
cache-read-only: true

Expand All @@ -42,7 +42,7 @@ jobs:
java-version: 17

- name: Gradle cache
uses: gradle/actions/setup-gradle@v3
uses: gradle/actions/setup-gradle@v4
with:
cache-read-only: true

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/generate_dependency_graph.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
java-version: 17

- name: Gradle cache
uses: gradle/actions/setup-gradle@v3
uses: gradle/actions/setup-gradle@v4
with:
cache-read-only: true

Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/publish_docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
java-version: 17

- name: Gradle cache
uses: gradle/actions/setup-gradle@v3
uses: gradle/actions/setup-gradle@v4
with:
cache-read-only: true

Expand All @@ -38,7 +38,7 @@ jobs:

# Deploy to GitHub Pages
- name: Deploy GitHub Pages
uses: JamesIves/github-pages-deploy-action@v4.6.4
uses: JamesIves/github-pages-deploy-action@v4.6.9
with:
BRANCH: gh-pages
FOLDER: build/docs/
4 changes: 2 additions & 2 deletions .github/workflows/publish_release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
java-version: 17

- name: Gradle cache
uses: gradle/actions/setup-gradle@v3
uses: gradle/actions/setup-gradle@v4
with:
cache-read-only: true

Expand Down Expand Up @@ -77,5 +77,5 @@ jobs:
tag_name: ${{ env.PROJECT_VERSION }}
release_name: ${{ env.PROJECT_VERSION }}
body_path: ${{ github.workspace }}/RELEASE_NOTES.md
draft: false
draft: true
prerelease: false
4 changes: 2 additions & 2 deletions .github/workflows/run_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
java-version: 17

- name: Gradle cache
uses: gradle/actions/setup-gradle@v3
uses: gradle/actions/setup-gradle@v4
with:
cache-read-only: false

Expand All @@ -42,7 +42,7 @@ jobs:
java-version: 17

- name: Gradle cache
uses: gradle/actions/setup-gradle@v3
uses: gradle/actions/setup-gradle@v4
with:
cache-read-only: false

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/run_ui_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
java-version: 17

- name: Gradle cache
uses: gradle/actions/setup-gradle@v3
uses: gradle/actions/setup-gradle@v4
with:
cache-read-only: false

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/sonar_cloud.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
java-version: 17

- name: Gradle cache
uses: gradle/actions/setup-gradle@v3
uses: gradle/actions/setup-gradle@v4
with:
cache-read-only: true

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/update_verification_metadata.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
java-version: 17

- name: Gradle cache
uses: gradle/actions/setup-gradle@v3
uses: gradle/actions/setup-gradle@v4
with:
cache-read-only: true

Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/validate_public_api.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
java-version: 17

- name: Gradle cache
uses: gradle/actions/setup-gradle@v3
uses: gradle/actions/setup-gradle@v4
with:
cache-read-only: true

Expand All @@ -28,10 +28,10 @@ jobs:
bash ./scripts/process_api_changes.sh

- name: Comment on PR
uses: thollander/actions-comment-pull-request@v2
uses: thollander/actions-comment-pull-request@v3
with:
filePath: "${{ github.workspace }}/api_changes.md"
comment_tag: api_changes
file-path: "${{ github.workspace }}/api_changes.md"
comment-tag: api_changes
mode: recreate

- name: Check if successful
Expand Down
22 changes: 11 additions & 11 deletions 3ds2/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@
*/

plugins {
id 'com.android.library'
id 'kotlin-android'
id 'kotlin-parcelize'
alias libs.plugins.android.library
alias libs.plugins.kotlin.android
alias libs.plugins.kotlin.parcelize
}

// Maven artifact
Expand All @@ -21,11 +21,11 @@ apply from: "${rootDir}/config/gradle/sharedTasks.gradle"

android {
namespace 'com.adyen.checkout.adyen3ds2'
compileSdk compile_sdk_version
compileSdk libs.versions.compile.sdk.get().toInteger()

defaultConfig {
minSdk min_sdk_version
targetSdk target_sdk_version
minSdk libs.versions.min.sdk.get().toInteger()
targetSdk libs.versions.target.sdk.get().toInteger()

testInstrumentationRunner 'androidx.test.runner.AndroidJUnitRunner'
consumerProguardFiles "consumer-rules.pro"
Expand All @@ -41,14 +41,14 @@ dependencies {
api project(':ui-core')

// Dependencies
api libraries.adyen3ds2
api libs.adyen3ds2

//Tests
testImplementation testFixtures(project(':test-core'))
testImplementation testFixtures(project(':components-core'))
testImplementation testFixtures(project(':ui-core'))
testImplementation testLibraries.json
testImplementation testLibraries.junit5
testImplementation testLibraries.mockito
testImplementation testLibraries.kotlinCoroutines
testImplementation libs.json
testImplementation libs.bundles.junit
testImplementation libs.bundles.mockito
testImplementation libs.bundles.kotlin.coroutines.test
}
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,15 @@ package com.adyen.checkout.adyen3ds2.internal.data.api

import com.adyen.checkout.adyen3ds2.internal.data.model.SubmitFingerprintRequest
import com.adyen.checkout.adyen3ds2.internal.data.model.SubmitFingerprintResponse
import com.adyen.checkout.core.DispatcherProvider
import com.adyen.checkout.core.internal.data.api.HttpClient
import com.adyen.checkout.core.internal.data.api.post
import kotlinx.coroutines.CoroutineDispatcher
import kotlinx.coroutines.Dispatchers
import kotlinx.coroutines.withContext

internal class SubmitFingerprintService(
private val httpClient: HttpClient,
private val coroutineDispatcher: CoroutineDispatcher = Dispatchers.IO,
private val coroutineDispatcher: CoroutineDispatcher = DispatcherProvider.IO,
) {

suspend fun submitFingerprint(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,11 +39,11 @@ import com.adyen.checkout.components.core.internal.ui.model.CommonComponentParam
import com.adyen.checkout.components.core.internal.ui.model.DropInOverrideParams
import com.adyen.checkout.components.core.internal.util.get
import com.adyen.checkout.components.core.internal.util.viewModelFactory
import com.adyen.checkout.core.DispatcherProvider
import com.adyen.checkout.core.internal.data.api.HttpClientFactory
import com.adyen.checkout.core.internal.util.LocaleProvider
import com.adyen.checkout.ui.core.internal.DefaultRedirectHandler
import com.adyen.threeds2.ThreeDS2Service
import kotlinx.coroutines.Dispatchers

class Adyen3DS2ComponentProvider
@RestrictTo(RestrictTo.Scope.LIBRARY_GROUP)
Expand Down Expand Up @@ -105,7 +105,7 @@ constructor(
adyen3DS2Serializer = adyen3DS2DetailsParser,
redirectHandler = redirectHandler,
threeDS2Service = ThreeDS2Service.INSTANCE,
coroutineDispatcher = Dispatchers.Default,
coroutineDispatcher = DispatcherProvider.Default,
application = application,
analyticsManager = analyticsManager,
)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -189,8 +189,7 @@ internal class DefaultAdyen3DS2DelegateTest(
assertTrue(exceptionFlow.latestValue is ComponentException)
}

// commenting this out because of failing tests, should be fixed later in collaboration with the 3DS2 team
// @Test
@Test
fun `3ds2 sdk throws an exception while initializing, then an exception emitted`() = runTest {
val error = InvalidInputException("test", null)
threeDS2Service.initializeError = error
Expand All @@ -203,8 +202,7 @@ internal class DefaultAdyen3DS2DelegateTest(
assertEquals(error, exceptionFlow.latestValue.cause)
}

// commenting this out because of failing tests, should be fixed later in collaboration with the 3DS2 team
// @Test
@Test
fun `3ds2 sdk returns an initialization error, then details are emitted`() = runTest {
val transStatus = "X"
val additionalDetails = "mockAdditionalDetails"
Expand Down Expand Up @@ -357,8 +355,7 @@ internal class DefaultAdyen3DS2DelegateTest(
transaction.assertDoChallengeCalled()
}

// commenting this out because of failing tests, should be fixed later in collaboration with the 3DS2 team
// @Test
@Test
fun `challenge fails, then an exception is emitted`() = runTest {
initializeChallengeTransaction(this).apply {
shouldThrowError = true
Expand Down Expand Up @@ -418,8 +415,7 @@ internal class DefaultAdyen3DS2DelegateTest(
@DisplayName("when transaction is")
inner class TransactionTest {

// commenting this out because of failing tests, should be fixed later in collaboration with the 3DS2 team
// @Test
@Test
fun `completed, then details are emitted`() = runTest {
val details =
JSONObject("{\"threeds2.challengeResult\":\"eyJ0cmFuc1N0YXR1cyI6InRyYW5zYWN0aW9uU3RhdHVzIn0=\"}")
Expand All @@ -438,8 +434,7 @@ internal class DefaultAdyen3DS2DelegateTest(
assertEquals(expected.details.toString(), detailsFlow.latestValue.details.toString())
}

// commenting this out because of failing tests, should be fixed later in collaboration with the 3DS2 team
// @Test
@Test
fun `completed and creating details fails, then an error is emitted`() = runTest {
val error = ComponentException("test")
// We have to mock the serializer in order to throw an exception
Expand Down Expand Up @@ -487,8 +482,7 @@ internal class DefaultAdyen3DS2DelegateTest(
assertNotNull(detailsFlow.latestValue.details)
}

// commenting this out because of failing tests, should be fixed later in collaboration with the 3DS2 team
// @Test
@Test
fun `error, then details are emitted`() = runTest {
val detailsFlow = delegate.detailsFlow.test(testScheduler)

Expand Down Expand Up @@ -636,9 +630,8 @@ internal class DefaultAdyen3DS2DelegateTest(
analyticsManager.assertLastEventEquals(expectedDisplayedEvent)
}

// commenting this out because of failing tests, should be fixed later in collaboration with the 3DS2 team
// @ParameterizedTest
// @MethodSource("com.adyen.checkout.adyen3ds2.internal.ui.DefaultAdyen3DS2DelegateTest#challengeResult")
@ParameterizedTest
@MethodSource("com.adyen.checkout.adyen3ds2.internal.ui.DefaultAdyen3DS2DelegateTest#challengeResult")
fun `when challenge result is returned, then event is tracked`(
challengeResult: ChallengeResult,
analyticsResult: ThreeDS2Events.Result
Expand All @@ -655,8 +648,7 @@ internal class DefaultAdyen3DS2DelegateTest(
}
}

// commenting this out because of failing tests, should be fixed later in collaboration with the 3DS2 team
// @Test
@Test
fun `when details are emitted, then state is cleared`() = runTest {
val savedStateHandle = SavedStateHandle().apply {
set(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package com.adyen.checkout.adyen3ds2.internal.ui
import com.adyen.threeds2.ChallengeResult
import com.adyen.threeds2.ChallengeStatusHandler
import org.junit.jupiter.api.BeforeEach
import org.junit.jupiter.api.Test

internal class SharedChallengeStatusHandlerTest {

Expand All @@ -11,8 +12,7 @@ internal class SharedChallengeStatusHandlerTest {
SharedChallengeStatusHandler.reset()
}

// commenting this out because of failing tests, should be fixed later in collaboration with the 3DS2 team
// @Test
@Test
fun `when onCompletion is triggered, then listener is called`() {
val onCompletionListener = TestOnCompletionListener()
SharedChallengeStatusHandler.onCompletionListener = onCompletionListener
Expand All @@ -22,8 +22,7 @@ internal class SharedChallengeStatusHandlerTest {
onCompletionListener.assertOnCompletionCalled()
}

// commenting this out because of failing tests, should be fixed later in collaboration with the 3DS2 team
// @Test
@Test
fun `when onCompletion is triggered and no listener is set, then onCompletion is queued until a listener is set`() {
val onCompletionListener = TestOnCompletionListener()
SharedChallengeStatusHandler.onCompletion(ChallengeResult.Completed("test"))
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ internal class Adyen3DS2ComponentParamsMapperTest {
shopperLocale = Locale.GERMAN,
environment = Environment.EUROPE,
clientKey = TEST_CLIENT_KEY_2,
analyticsParams = AnalyticsParams(AnalyticsParamsLevel.NONE, TEST_CLIENT_KEY_2),
analyticsParams = AnalyticsParams(AnalyticsParamsLevel.INITIAL, TEST_CLIENT_KEY_2),
isCreatedByDropIn = true,
amount = Amount(
currency = "CAD",
Expand Down
12 changes: 6 additions & 6 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,23 +31,23 @@ Import the corresponding module in your `build.gradle` file.

For Drop-in:
```groovy
implementation "com.adyen.checkout:drop-in-compose:5.7.0"
implementation "com.adyen.checkout:drop-in-compose:5.8.0"
```
For the Credit Card component:
```groovy
implementation "com.adyen.checkout:card:5.7.0"
implementation "com.adyen.checkout:components-compose:5.7.0"
implementation "com.adyen.checkout:card:5.8.0"
implementation "com.adyen.checkout:components-compose:5.8.0"
```

### Without Jetpack Compose

For Drop-in:
```groovy
implementation "com.adyen.checkout:drop-in:5.7.0"
implementation "com.adyen.checkout:drop-in:5.8.0"
```
For the Credit Card component:
```groovy
implementation "com.adyen.checkout:card:5.7.0"
implementation "com.adyen.checkout:card:5.8.0"
```

The library is available on [Maven Central][mavenRepo].
Expand All @@ -71,7 +71,7 @@ Please let us know if you find any issues.

For development and testing purposes the project is accompanied by a test app. See [here](example-app/README.md) how to set it up and run it.

To test your integration you could use [Adyen Test Cards Android][adyenTestCardsAndroid]. This will allow you to easily prefill test payment method information.
To test your integration you could use [Adyen Test Cards Android][adyenTestCardsAndroid]. This will allow you to easily autofill test payment method information.

## Support

Expand Down
Loading
Loading