Merge pull request #1691 from Adyen/feature/upi_intent_show_error_if_…

…no_app_is_selected

UPI - Show disclaimer when Continue is pressed without a selection

RELEASE_NOTES.md

@@ -8,20 +8,5 @@
 [//]: # (## Deprecated)
 [//]: # ( - Configurations public constructor are deprecated, please use each Configuration's builder to make a Configuration object)
 
-## New
-- For Google Pay on Advanced flow, `onSubmit` now returns`threeDS2SdkVersion` in the `paymentMethod` object that you must pass in your [`/payments`](https://docs.adyen.com/api-explorer/Checkout/71/post/payments) request to correctly trigger the 3D Secure 2 flow.
-
-## Fixed
-- On Android API versions 21 to 25, the `NoSuchMethodError` no longer occurs during the 3D Secure 2 challenge flow.
-- When [using R8 to shrink your code](https://developer.android.com/build/shrink-code), `CIRCULAR REFERENCE: com.android.tools.r8.utils.b: Missing class...` errors no longer occur.
-
-## Changed
-- Dependency versions:
-  | Name                                                                                                         | Version                       |
-  |--------------------------------------------------------------------------------------------------------------|-------------------------------|
-  | [Adyen 3DS2](https://github.com/Adyen/adyen-3ds2-android/releases/tag/2.2.19)                                | **2.2.19**                    |
-  | [Kotlin](https://github.com/JetBrains/kotlin/releases/tag/v1.9.24)                                           | **1.9.24**                    |
-  | [Android Gradle plugin](https://developer.android.com/build/releases/gradle-plugin)                          | **8.4.1**                     |
-  | [AndroidX Compose Compiler](https://developer.android.com/jetpack/androidx/releases/compose-compiler#1.5.14) | **1.5.14**                    |
-  | [Kotlin coroutines](https://github.com/Kotlin/kotlinx.coroutines/releases/tag/1.8.1)                         | **1.8.1**                     |
-  | [AndroidX Fragment](https://developer.android.com/jetpack/androidx/releases/fragment#1.7.1)                  | **1.7.1**                     |
+## Improved
+- For UPI Intent an error message will be shown when "Continue" button is pressed without selecting any UPI option.

ach/src/main/java/com/adyen/checkout/ach/internal/ui/DefaultACHDirectDebitDelegate.kt

@@ -373,8 +373,6 @@ internal class DefaultACHDirectDebitDelegate(
 
     override fun shouldShowSubmitButton(): Boolean = isConfirmationRequired() && componentParams.isSubmitButtonVisible
 
-    override fun shouldEnableSubmitButton(): Boolean = true
-
     companion object {
         private const val ENCRYPTION_KEY_FOR_BANK_ACCOUNT_NUMBER = "bankAccountNumber"
         private const val ENCRYPTION_KEY_FOR_BANK_LOCATION_ID = "bankLocationId"

ach/src/test/java/com/adyen/checkout/ach/internal/ui/DefaultACHDirectDebitDelegateTest.kt

@@ -605,15 +605,6 @@ internal class DefaultACHDirectDebitDelegateTest(
         }
     }
 
-    @Nested
-    inner class SubmitButtonEnableTest {
-
-        @Test
-        fun `when shouldEnableSubmitButton is called, then true is returned`() {
-            assertTrue(delegate.shouldEnableSubmitButton())
-        }
-    }
-
     @Nested
     inner class SubmitHandlerTest {
 

bacs/src/main/java/com/adyen/checkout/bacs/internal/ui/DefaultBacsDirectDebitDelegate.kt

@@ -218,8 +218,6 @@ internal class DefaultBacsDirectDebitDelegate(
 
     override fun shouldShowSubmitButton(): Boolean = isConfirmationRequired() && componentParams.isSubmitButtonVisible
 
-    override fun shouldEnableSubmitButton(): Boolean = true
-
     override fun setInteractionBlocked(isInteractionBlocked: Boolean) {
         submitHandler.setInteractionBlocked(isInteractionBlocked)
     }

bacs/src/test/java/com/adyen/checkout/bacs/internal/DefaultBacsDirectDebitDelegateTest.kt

@@ -477,15 +477,6 @@ internal class DefaultBacsDirectDebitDelegateTest(
         }
     }
 
-    @Nested
-    inner class SubmitButtonEnableTest {
-
-        @Test
-        fun `when shouldEnableSubmitButton is called, then true is returned`() {
-            assertTrue(delegate.shouldEnableSubmitButton())
-        }
-    }
-
     @Nested
     inner class SubmitHandlerTest {
 

blik/src/main/java/com/adyen/checkout/blik/internal/ui/DefaultBlikDelegate.kt

@@ -162,8 +162,6 @@ internal class DefaultBlikDelegate(
 
     override fun shouldShowSubmitButton(): Boolean = isConfirmationRequired() && componentParams.isSubmitButtonVisible
 
-    override fun shouldEnableSubmitButton(): Boolean = true
-
     override fun setInteractionBlocked(isInteractionBlocked: Boolean) {
         submitHandler.setInteractionBlocked(isInteractionBlocked)
     }

blik/src/main/java/com/adyen/checkout/blik/internal/ui/StoredBlikDelegate.kt

@@ -141,8 +141,6 @@ internal class StoredBlikDelegate(
 
     override fun shouldShowSubmitButton(): Boolean = isConfirmationRequired() && componentParams.isSubmitButtonVisible
 
-    override fun shouldEnableSubmitButton(): Boolean = true
-
     override fun setInteractionBlocked(isInteractionBlocked: Boolean) {
         submitHandler.setInteractionBlocked(isInteractionBlocked)
     }

blik/src/test/java/com/adyen/checkout/blik/internal/ui/DefaultBlikDelegateTest.kt

@@ -218,15 +218,6 @@ internal class DefaultBlikDelegateTest(
         }
     }
 
-    @Nested
-    inner class SubmitButtonEnableTest {
-
-        @Test
-        fun `when shouldEnableSubmitButton is called, then true is returned`() {
-            assertTrue(delegate.shouldEnableSubmitButton())
-        }
-    }
-
     @Nested
     inner class SubmitHandlerTest {
 

blik/src/test/java/com/adyen/checkout/blik/internal/ui/StoredBlikDelegateTest.kt

@@ -81,15 +81,6 @@ class StoredBlikDelegateTest(
         }
     }
 
-    @Nested
-    inner class SubmitButtonEnableTest {
-
-        @Test
-        fun `when shouldEnableSubmitButton is called, then true is returned`() {
-            assertTrue(delegate.shouldEnableSubmitButton())
-        }
-    }
-
     @Nested
     inner class SubmitHandlerTest {
 

boleto/src/main/java/com/adyen/checkout/boleto/internal/ui/DefaultBoletoDelegate.kt

@@ -303,8 +303,6 @@ internal class DefaultBoletoDelegate(
 
     override fun shouldShowSubmitButton(): Boolean = isConfirmationRequired() && componentParams.isSubmitButtonVisible
 
-    override fun shouldEnableSubmitButton(): Boolean = true
-
     override fun onCleared() {
         removeObserver()
         analyticsManager.clear(this)

boleto/src/test/java/com/adyen/checkout/boleto/internal/ui/DefaultBoletoDelegateTest.kt

@@ -481,15 +481,6 @@ internal class DefaultBoletoDelegateTest(
         }
     }
 
-    @Nested
-    inner class SubmitButtonEnableTest {
-
-        @Test
-        fun `when shouldEnableSubmitButton is called, then true is returned`() {
-            assertTrue(delegate.shouldEnableSubmitButton())
-        }
-    }
-
     @Nested
     inner class SubmitHandlerTest {
         @Test

card/src/main/java/com/adyen/checkout/card/internal/ui/DefaultCardDelegate.kt

@@ -812,8 +812,6 @@ class DefaultCardDelegate(
 
     override fun shouldShowSubmitButton(): Boolean = isConfirmationRequired() && componentParams.isSubmitButtonVisible
 
-    override fun shouldEnableSubmitButton(): Boolean = true
-
     override fun setOnBinValueListener(listener: ((binValue: String) -> Unit)?) {
         onBinValueListener = listener
     }

card/src/main/java/com/adyen/checkout/card/internal/ui/StoredCardDelegate.kt

@@ -419,8 +419,6 @@ internal class StoredCardDelegate(
 
     override fun shouldShowSubmitButton(): Boolean = isConfirmationRequired() && componentParams.isSubmitButtonVisible
 
-    override fun shouldEnableSubmitButton(): Boolean = true
-
     override fun updateAddressInputData(update: AddressInputModel.() -> Unit) {
         // no ops
     }

card/src/test/java/com/adyen/checkout/card/internal/ui/DefaultCardDelegateTest.kt

@@ -1006,15 +1006,6 @@ internal class DefaultCardDelegateTest(
         }
     }
 
-    @Nested
-    inner class SubmitButtonEnableTest {
-
-        @Test
-        fun `when shouldEnableSubmitButton is called, then true is returned`() {
-            assertTrue(delegate.shouldEnableSubmitButton())
-        }
-    }
-
     @Nested
     inner class SubmitHandlerTest {
 

card/src/test/java/com/adyen/checkout/card/internal/ui/StoredCardDelegateTest.kt

@@ -394,15 +394,6 @@ internal class StoredCardDelegateTest(
         }
     }
 
-    @Nested
-    inner class SubmitButtonEnableTest {
-
-        @Test
-        fun `when shouldEnableSubmitButton is called, then true is returned`() {
-            assertTrue(delegate.shouldEnableSubmitButton())
-        }
-    }
-
     @Nested
     inner class SubmitHandlerTest {
 

cashapppay/src/main/java/com/adyen/checkout/cashapppay/internal/ui/DefaultCashAppPayDelegate.kt

@@ -317,8 +317,6 @@ constructor(
 
     override fun shouldShowSubmitButton(): Boolean = isConfirmationRequired() && componentParams.isSubmitButtonVisible
 
-    override fun shouldEnableSubmitButton(): Boolean = true
-
     internal fun setInteractionBlocked(isInteractionBlocked: Boolean) {
         submitHandler.setInteractionBlocked(isInteractionBlocked)
     }

cashapppay/src/test/java/com/adyen/checkout/cashapppay/internal/ui/DefaultCashAppPayDelegateTest.kt

@@ -170,15 +170,6 @@ internal class DefaultCashAppPayDelegateTest(
         }
     }
 
-    @Nested
-    inner class SubmitButtonEnableTest {
-
-        @Test
-        fun `when shouldEnableSubmitButton is called, then true is returned`() {
-            assertTrue(delegate.shouldEnableSubmitButton())
-        }
-    }
-
     @Nested
     inner class SubmitHandlerTest {
 

econtext/src/main/java/com/adyen/checkout/econtext/internal/ui/DefaultEContextDelegate.kt

@@ -226,8 +226,6 @@ internal class DefaultEContextDelegate<
         return isConfirmationRequired() && componentParams.isSubmitButtonVisible
     }
 
-    override fun shouldEnableSubmitButton(): Boolean = true
-
     override fun setInteractionBlocked(isInteractionBlocked: Boolean) {
         submitHandler.setInteractionBlocked(isInteractionBlocked)
     }

econtext/src/test/java/com/adyen/checkout/econtext/internal/ui/DefaultEContextDelegateTest.kt

@@ -223,15 +223,6 @@ internal class DefaultEContextDelegateTest(
         }
     }
 
-    @Nested
-    inner class SubmitButtonEnableTest {
-
-        @Test
-        fun `when shouldEnableSubmitButton is called, then true is returned`() {
-            assertTrue(delegate.shouldEnableSubmitButton())
-        }
-    }
-
     @Nested
     inner class SubmitHandlerTest {
 

giftcard/src/main/java/com/adyen/checkout/giftcard/internal/ui/DefaultGiftCardDelegate.kt

@@ -272,8 +272,6 @@ internal class DefaultGiftCardDelegate(
 
     override fun shouldShowSubmitButton(): Boolean = isConfirmationRequired() && componentParams.isSubmitButtonVisible
 
-    override fun shouldEnableSubmitButton(): Boolean = true
-
     override fun setInteractionBlocked(isInteractionBlocked: Boolean) {
         submitHandler.setInteractionBlocked(isInteractionBlocked)
     }

giftcard/src/test/java/com/adyen/checkout/giftcard/internal/ui/DefaultGiftCardDelegateTest.kt

@@ -205,15 +205,6 @@ internal class DefaultGiftCardDelegateTest(
         }
     }
 
-    @Nested
-    inner class SubmitButtonEnableTest {
-
-        @Test
-        fun `when shouldEnableSubmitButton is called, then true is returned`() {
-            assertTrue(delegate.shouldEnableSubmitButton())
-        }
-    }
-
     @Nested
     inner class SubmitHandlerTest {
 

issuer-list/src/main/java/com/adyen/checkout/issuerlist/internal/ui/DefaultIssuerListDelegate.kt

@@ -178,8 +178,6 @@ internal class DefaultIssuerListDelegate<
 
     override fun shouldShowSubmitButton(): Boolean = isConfirmationRequired() && componentParams.isSubmitButtonVisible
 
-    override fun shouldEnableSubmitButton(): Boolean = true
-
     override fun setInteractionBlocked(isInteractionBlocked: Boolean) {
         submitHandler.setInteractionBlocked(isInteractionBlocked)
     }

issuer-list/src/test/java/com/adyen/checkout/issuerlist/internal/ui/DefaultIssuerListDelegateTest.kt

@@ -260,15 +260,6 @@ internal class DefaultIssuerListDelegateTest(
         }
     }
 
-    @Nested
-    inner class SubmitButtonEnableTest {
-
-        @Test
-        fun `when shouldEnableSubmitButton is called, then true is returned`() {
-            assertTrue(delegate.shouldEnableSubmitButton())
-        }
-    }
-
     @Nested
     inner class SubmitHandlerTest {
 

mbway/src/main/java/com/adyen/checkout/mbway/internal/ui/DefaultMBWayDelegate.kt

@@ -178,8 +178,6 @@ internal class DefaultMBWayDelegate(
 
     override fun shouldShowSubmitButton(): Boolean = isConfirmationRequired() && componentParams.isSubmitButtonVisible
 
-    override fun shouldEnableSubmitButton(): Boolean = true
-
     override fun setInteractionBlocked(isInteractionBlocked: Boolean) {
         submitHandler.setInteractionBlocked(isInteractionBlocked)
     }

mbway/src/test/java/com/adyen/checkout/mbway/internal/ui/DefaultMBWayDelegateTest.kt

@@ -223,15 +223,6 @@ internal class DefaultMBWayDelegateTest(
         }
     }
 
-    @Nested
-    inner class SubmitButtonEnableTest {
-
-        @Test
-        fun `when shouldEnableSubmitButton is called, then true is returned`() {
-            assertTrue(delegate.shouldEnableSubmitButton())
-        }
-    }
-
     @Nested
     inner class SubmitHandlerTest {
 

online-banking-core/src/main/java/com/adyen/checkout/onlinebankingcore/internal/ui/DefaultOnlineBankingDelegate.kt

@@ -188,8 +188,6 @@ internal class DefaultOnlineBankingDelegate<
 
     override fun shouldShowSubmitButton(): Boolean = isConfirmationRequired() && componentParams.isSubmitButtonVisible
 
-    override fun shouldEnableSubmitButton(): Boolean = true
-
     override fun setInteractionBlocked(isInteractionBlocked: Boolean) {
         submitHandler.setInteractionBlocked(isInteractionBlocked)
     }

online-banking-core/src/test/java/com/adyen/checkout/onlinebankingcore/internal/ui/DefaultOnlineBankingDelegateTest.kt

@@ -204,15 +204,6 @@ internal class DefaultOnlineBankingDelegateTest(
         }
     }
 
-    @Nested
-    inner class SubmitButtonEnableTest {
-
-        @Test
-        fun `when shouldEnableSubmitButton is called, then true is returned`() {
-            assertTrue(delegate.shouldEnableSubmitButton())
-        }
-    }
-
     @Nested
     inner class SubmitHandlerTest {
 

sepa/src/main/java/com/adyen/checkout/sepa/internal/ui/DefaultSepaDelegate.kt

@@ -152,8 +152,6 @@ internal class DefaultSepaDelegate(
 
     override fun shouldShowSubmitButton(): Boolean = isConfirmationRequired() && componentParams.isSubmitButtonVisible
 
-    override fun shouldEnableSubmitButton(): Boolean = true
-
     override fun setInteractionBlocked(isInteractionBlocked: Boolean) {
         submitHandler.setInteractionBlocked(isInteractionBlocked)
     }

sepa/src/test/java/com/adyen/checkout/sepa/internal/ui/DefaultSepaDelegateTest.kt

@@ -150,15 +150,6 @@ internal class DefaultSepaDelegateTest(
         }
     }
 
-    @Nested
-    inner class SubmitButtonEnableTest {
-
-        @Test
-        fun `when shouldEnableSubmitButton is called, then true is returned`() {
-            assertTrue(delegate.shouldEnableSubmitButton())
-        }
-    }
-
     @Nested
     inner class SubmitHandlerTest {
 

ui-core/api/ui-core.api

@@ -62,10 +62,6 @@ public final class com/adyen/checkout/ui/core/internal/ui/PaymentComponentUIEven
 	public static final field INSTANCE Lcom/adyen/checkout/ui/core/internal/ui/PaymentComponentUIEvent$InvalidUI;
 }
 
-public final class com/adyen/checkout/ui/core/internal/ui/PaymentComponentUIEvent$StateUpdated : com/adyen/checkout/ui/core/internal/ui/PaymentComponentUIEvent {
-	public static final field INSTANCE Lcom/adyen/checkout/ui/core/internal/ui/PaymentComponentUIEvent$StateUpdated;
-}
-
 public final class com/adyen/checkout/ui/core/internal/ui/PaymentComponentUIState$Blocked : com/adyen/checkout/ui/core/internal/ui/PaymentComponentUIState {
 	public static final field INSTANCE Lcom/adyen/checkout/ui/core/internal/ui/PaymentComponentUIState$Blocked;
 }