Fix manually suppressed TODOs

Adyen · Mar 18, 2024 · 5789f1f · 5789f1f
1 parent f700c6e
commit 5789f1f
Show file tree

Hide file tree

Showing 5 changed files with 4 additions and 13 deletions.
diff --git a/card/src/main/java/com/adyen/checkout/card/internal/ui/view/CardView.kt b/card/src/main/java/com/adyen/checkout/card/internal/ui/view/CardView.kt
@@ -302,7 +302,7 @@ class CardView @JvmOverloads constructor(
             )
             setDualBrandedCardImages(detectedCardTypes, cardOutputData.cardNumberState.validation)
 
-            // TODO: 29/01/2021 get this logic from OutputData
+            // TODO 29/01/2021 get this logic from OutputData
             val isAmex = detectedCardTypes.any { it.cardBrand == CardBrand(cardType = CardType.AMERICAN_EXPRESS) }
             binding.editTextCardNumber.setAmexCardFormat(isAmex)
 

diff --git a/components-core/src/main/java/com/adyen/checkout/components/core/action/VoucherAction.kt b/components-core/src/main/java/com/adyen/checkout/components/core/action/VoucherAction.kt
@@ -33,7 +33,7 @@ data class VoucherAction(
     var alternativeReference: String? = null,
     var merchantName: String? = null,
     var merchantReference: String? = null,
-    // TODO: remove url when it's fixed from backend side
+    // TODO remove url when it's fixed from backend side
     var url: String? = null,
     var downloadUrl: String? = null,
     var instructionsUrl: String? = null,

diff --git a/config/detekt/detekt-baseline.xml b/config/detekt/detekt-baseline.xml
@@ -11,14 +11,5 @@
     <ManuallySuppressedIssues>
     </ManuallySuppressedIssues>
     <CurrentIssues>
-        <ID>ForbiddenComment:Logger.kt$Logger$// TODO: 14/02/2019 The idea is for this class to have a system where we can send a stream of logs to the merchant</ID>
-        <ID>ForbiddenComment:CardView.kt$CardView$// TODO: 29/01/2021 get this logic from OutputData</ID>
-        <ID>ForbiddenComment:VoucherAction.kt$VoucherAction$// TODO: remove url when it's fixed from backend side</ID>
-        <ID>ForbiddenComment:ActionComponentDialogFragment.kt$ActionComponentDialogFragment$// TODO: trigger download image flow when user accept storage permission after checking permission type</ID>
-        <ID>ForbiddenComment:ActionComponentDialogFragment.kt$ActionComponentDialogFragment$// TODO: checkout_rationale_title_storage_permission and checkout_rationale_message_storage_permission</ID>
-        <ID>ForbiddenComment:ActionComponentDialogFragment.kt$ActionComponentDialogFragment$// TODO: can be reused based on required permission</ID>
-        <ID>ForbiddenComment:DefaultVoucherDelegate.kt$DefaultVoucherDelegate$// TODO: remove action.url when it's fixed from backend side</ID>
-        <ID>ForbiddenComment:CheckoutSessionInitializer.kt$CheckoutSessionInitializer$// TODO: Once Backend provides the correct amount in the SessionSetupResponse use that in SessionDetails instead of</ID>
-        <ID>ForbiddenComment:SessionDetails.kt$// TODO: Once Backend provides the correct amount in the SessionSetupResponse use that in SessionDetails</ID>
     </CurrentIssues>
 </SmellBaseline>
diff --git a/...ore/src/main/java/com/adyen/checkout/sessions/core/internal/CheckoutSessionInitializer.kt b/...ore/src/main/java/com/adyen/checkout/sessions/core/internal/CheckoutSessionInitializer.kt
@@ -33,7 +33,7 @@ internal class CheckoutSessionInitializer(
     private val sessionService = SessionService(httpClient)
     private val sessionRepository = SessionRepository(sessionService, clientKey)
 
-    // TODO: Once Backend provides the correct amount in the SessionSetupResponse use that in SessionDetails instead of
+    // TODO Once Backend provides the correct amount in the SessionSetupResponse use that in SessionDetails instead of
     //  override Amount
     suspend fun setupSession(overrideAmount: Amount?): CheckoutSessionResult = withContext(coroutineDispatcher) {
         sessionRepository.setupSession(

diff --git a/voucher/src/main/java/com/adyen/checkout/voucher/internal/ui/DefaultVoucherDelegate.kt b/voucher/src/main/java/com/adyen/checkout/voucher/internal/ui/DefaultVoucherDelegate.kt
@@ -113,7 +113,7 @@ internal class DefaultVoucherDelegate(
         action: VoucherAction,
         config: VoucherPaymentMethodConfig
     ) {
-        // TODO: remove action.url when it's fixed from backend side
+        // TODO remove action.url when it's fixed from backend side
         val downloadUrl = action.downloadUrl ?: action.url
         val storeAction = downloadUrl?.let { url ->
             VoucherStoreAction.DownloadPdf(url)