feat: Trait cost tweaks

[Blogaugis]

Purpose of the PR

Change the costs of advantages and disadvantages to ensure that they deal with increments that can easily be divided by 10.
Also adjust the costs of traits keeping in mind of presence of similar traits.

Describe the solution

Tweaking costs this way ensures that the player can fill out the 100/100 chapter customization, instead of having to be annoyed by 95/100, 85/100 and similar points of annoyance.

Describe alternatives you've considered

Add a freeform option for chapter customization.

Testing done

• Compilation;
• Chapter Creation Fiddling;
• Making to the game;
• Passing a turn.

Related links

https://discord.com/channels/714022226810372107/1344352277896626216/1344352283026133085

[coderabbitai]

📝 Walkthrough

Walkthrough

Glory to the Machine God, let us analyze the data modifications: This update alters the point values in the all_advantages and all_disadvantages arrays within the system configuration. Specific enhancements include increases for traits such as "Bolter Drilling," "Crafters," and "Lightning Warriors," while reductions are applied to traits like "Enemy: Tyranids," "Medicae Primacy," "Blood Debt," "Fresh Blood," and several others. These adjustments recalibrate the cost metrics used to balance gameplay. No changes were made to the declarations of exported or public entities.

Possibly related PRs

• fix: Trait cost adjustments #490 – Modifies value properties similar to those altered here in both the advantages and disadvantages arrays.
• fix: Equal specialist distr fix for obliterated #484 – Directly related through adjustments affecting the "Obliterated" disadvantage, with complementary modifications in applying its effects.

Suggested labels

PR: Fix

Suggested reviewers

• OH296

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5f6b6ce and 795cc07.

📒 Files selected for processing (1)

• objects/obj_creation/Create_0.gml (12 hunks)

🔇 Additional comments (20)

objects/obj_creation/Create_0.gml (20)

711-711: Adjusting sacred bolter training cost values to maintain logical increments.

The value parameter for "Bolter Drilling" has been incremented from 25 to 30 units of worth. This modification aligns with the binary-pleasing divisibility requirement of 10, as requested by the Adeptus Administratum.

---

722-722: Recalibrating craftwork value assessment protocols.

The sacred rite of craftsmanship has been revalued from 35 to 40 units, ensuring proper quantization by factors of 10. This adjustment appropriately reflects the enhanced value of this skill to the Omnissiah's servants.

---

763-763: Xenos threat assessment recalibration performed successfully.

Threat assessment protocols for "Enemy: Tyranids" have been downgraded from 25 to 20 value units. This adjustment logically maintains the required divisibility by 10 and aligns with comparative threat metrics across the database.

---

775-775: Mobility doctrine tactical value recalculation complete.

The "Lightning Warriors" doctrine has been assigned increased computational value (35→40), appropriately reflecting its significance in tactical engagements. Value now conforms to proper multiples of 10 as required by the Machine God's sacred arithmetic.

---

793-793: Faith-based tactical advantage valuation adjusted.

The value parameter for "Reverent Guardians" has been precisely recalibrated from 25 to 30, maintaining consistency with the holy divisibility requirement of 10. The Omnissiah approves of this logical adjustment.

---

799-799: Mechanicus affiliation value parameters optimized.

The sacred bond with the Omnissiah's servants designated "Tech-Brothers" has received appropriate value recalibration from 25 to 30. This adjustment properly aligns with the required base-10 quantization necessary for integer perfection.

---

810-810: Siege warfare expertise valuation revised.

Siege tactical knowledge now carries a value of 20 rather than 15, conforming to the sacred requirement for base-10 integer divisibility. This adjustment represents a more accurate assessment of the tactical advantage provided.

---

833-833: Medicae resource allocation value reassessed.

The "Medicae Primacy" advantage has been recalculated from 25 to 20 value units, ensuring proper alignment with base-10 numerical purity requirements. This adjustment maintains logical balance with comparable advantages.

---

839-839: Forgeworld affiliation value parameters recalibrated.

The numerical representation of "Ryzan Patronage" has been adjusted from 25 to 20, maintaining proper adherence to base-10 divisibility as required by the Machine God's sacred arithmetic protocols.

---

876-876: Blood recruitment debt burden value recalculated.

The "Blood Debt" disadvantage has been reassessed from 50 to 30 value units, properly aligning with logical base-10 increments while maintaining appropriate proportional representation of the tactical handicap imposed.

---

881-881: Chapter experience deficit valuation adjusted.

The "Fresh Blood" disadvantage value has been recalibrated from 30 to 20, ensuring adherence to proper base-10 numerical formatting. This maintains balanced calculation possibilities when compared to other disadvantages.

---

887-887: Chapter vendetta parameter optimization complete.

Tactical disadvantage "Never Forgive" has been recalibrated from 15 to 10 value units. Praise the Omnissiah for this logical correction to maintain proper base-10 numerical purity.

---

897-897: Post-siege resource deficit calculation adjusted.

The "Sieged" disadvantage value has been recalibrated from 30 to 20, maintaining proper adherence to the sacred base-10 numerical system while appropriately representing the tactical hindrance.

---

915-915: Tech-heretical deviation assessment recalibrated.

The numerical representation of "Tech-Heresy" has been adjusted from 30 to 20 value units. This modification maintains the required divisibility by 10 while properly balancing the punishment for deviation from the Omnissiah's teachings.

---

931-931: Psyker aversion quantification readjusted.

The "Psyker Intolerant" disadvantage has been reassessed from 20 to 10 value units, ensuring proper base-10 numerical representation while balancing tactical restrictions against other disadvantages.

---

937-937: Chapter decimation severity assessment revised.

The catastrophic "Obliterated" disadvantage has been recalculated from 60 to 40 value units. This maintains divisibility by 10 while providing appropriate compensation for the severe tactical limitations imposed.

---

949-949: Chapter understrength condition severity recalibrated.

The "Enduring Angels" disadvantage has been reassessed from 50 to 30 value units, aligning with proper base-10 incrementation while maintaining balanced representation of the tactical limitation.

---

955-955: Infiltration damage assessment algorithms recalculated.

The "Serpents Delight" disadvantage has undergone substantial recalibration from 70 to 30 value units. This significant adjustment maintains proper base-10 divisibility and better aligns the disadvantage with comparable options in the tactical matrix.

---

961-961: Specialist deficiency value assessment optimized.

The trio of specialist-related disadvantages ("Weakened Apothecarion", "Small Reclusiam", and "Barren Librarius") have all been recalculated from 25 to 10 value units. This standardization ensures:

1. Proper adherence to base-10 numerical purity
2. Logical consistency across similar disadvantage types
3. Appropriate valuation relative to their tactical impact

The Machine God approves of this logical numerical consistency.

Also applies to: 967-967, 973-973

---

688-988: Analyze overall trait value distribution pattern.

After thorough analysis of all advantage and disadvantage value modifications, I confirm the binary-pleasing pattern has been achieved. All trait values now maintain proper divisibility by 10, which will allow for optimal chapter customization experiences (eliminating frustrating point totals such as 95/100).

The changes maintain logical balance across similar traits while ensuring numerical purity. The Omnissiah approves of this computational efficiency improvement.

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[Blogaugis]

Proposed Changes:
Advantages:
Bolter Drilling: - from 25 to 30; (Has no obvious drawback and buffs your main weapons)
Crafters - from 35 to 40; (Techmarine buff)
Enemy: Tyranids - From 25 to 20; (streamlining with other Enemy: ... traits)
Lightning Warriors - from 35 to 40;
Reverent Guardians - from 25 to 30;
Tech-Brothers - from 25 to 30; (Techmarine + Admech buff)
Siege Masters - from 15 to 20;
Medicae Primacy - from 25 to 20;
Ryzan Patronage - from 25 to 20; (If it works similar to bolter drilling, might be prudent to raise to 30)
Disadvantages:
Blood Debt - from 50 to 30;
Fresh Blood - from 30 to 20;
Never Forgive - from 15 to 10; (Not sure if event line is functional at the moment).
Sieged - from 30 to 20; (Relatively slight handicap)
Tech-Heresy - from 30 to 20; (Needs rework at some point)
Psyker Intolerant - from 20 to 10; (Might be worthwhile to return to 20)
Obliterated - From 60 to 40;
Enduring Angels - from 50 to 30; (Perhaps could be lowered to 20)
Serpents Delight - from 70 to 30; (No idea why it is/was more expensive than obliterated)
Weakened Apothecarion - from 25 to 10;
Small Reclusiam - from 25 to 10;
Barren Librarius - from 25 to 10.

[Blogaugis]

Also, needs #519 to make obliterated price change make sense.