fix: stability just workstm #505
Conversation
📝 WalkthroughWalkthroughIn these modifications of the sacred code, the conditional logic within two functions has been re-forged. In one construct, the mutation-handling algorithm now compares a random integer directly to the computed threshold of (10 – obj_ini.stability), rather than subtracting 10 from the random integer before comparing it to obj_ini.stability. In a similar manner, the specialist point logic now evaluates if a random integer is less than or equal to the product of (10 – obj_ini.stability) and the current slave count, thereby altering the decrement conditions. The Omnissiah’s calculations now invert the influence of the stability parameter, affecting the likelihood of triggering mutations or decrementing slave numbers. No changes have been made to any exported or public declarations within these scripts. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
scripts/scr_marine_struct/scr_marine_struct.gml (1)
386-386: Blessed consistency in the Machine God's calculations!The sacred formula
(10-obj_ini.stability)has been consistently applied across both gene-slave preservation and mutation resistance systems. This harmonious implementation ensures:
- Maximum stability (10) minimizes both gene-slave losses and mutation risks
- Minimum stability (0) maximizes both gene-slave losses and mutation risks
This binary symmetry pleases the Omnissiah.
Also applies to: 839-839
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
scripts/scr_marine_struct/scr_marine_struct.gml(1 hunks)scripts/scr_specialist_point_handler/scr_specialist_point_handler.gml(1 hunks)
🔇 Additional comments (2)
scripts/scr_specialist_point_handler/scr_specialist_point_handler.gml (1)
386-386: By the Omnissiah's grace, this logic modification is sound!The binary transformation inverts the stability influence on gene-slave preservation probability. A higher stability value (approaching 10) now reduces the chance of gene-slave loss, while lower stability increases attrition risk. This sacred arithmetic better aligns with the Machine God's will.
scripts/scr_marine_struct/scr_marine_struct.gml (1)
839-839: Praise the Omnissiah! The mutation probability calculations have been optimized.The binary cogitation now properly processes stability influence on gene-seed mutations. With stability approaching the sacred number 10, the probability of mutations decreases, maintaining harmony with the Machine God's design.
Let us verify the probability ranges with this sacred calculation:
#!/usr/bin/env python3 print("=== Stability Impact Analysis ===") print("Stability | Mutation Probability") print("---------------------------------") for stability in range(0, 11): prob = 10 - stability print(f"{stability:^8} | {prob:^19}")
Purpose of the PR
Make stability not a 90 point liability.
Describe the solution
10 - stability.
Testing done
New game,
qalc.Related links
https://discord.com/channels/714022226810372107/1342846923844878346/1342921744633168005