fix: Realign and move potential indicators

[MCPO-Spartan-117]

Purpose of the PR

Realign tooltips and move indicators.

And remove tabs in whitespace spaces(brother, stop doing this, git patches hate this and i have to reformat it.)

Describe the solution

Changed values, more vars, delete tabs.

Testing done

Load save, check.

Related links

https://discord.com/channels/714022226810372107/1121959429546455050/1343103391936806975

[coderabbitai]

📝 Walkthrough

Walkthrough

Behold, the sacred adjustments to the scr_draw_management_unit function have been executed with precision. In this revision, the logic managing the rendering of unit specialist options has been recalibrated. The coordinate system has been updated such that the _circle_coords now initiates at [xx + 321, yy + 77], and a new _circle_radius value of 3 has been integrated. The drawing calculations have been restructured to incorporate this radius, with an additional loop modifying the _draw_coords by subtracting the radius from the first two dimensions before appending them to the potential_tooltip array. Variable declarations have been streamlined without altering the core logic defining specialist option validity. No alterations have been made to the exported or public entities.

Possibly related PRs

• feat: Rework and show all specialist potentials #499: This PR affects the same function by revising the drawing logic and coordinate computations used for displaying specialist potentials in a similar manner.

Suggested reviewers

• OH296

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[MCPO-Spartan-117]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[coderabbitai]

Actionable comments posted: 1

🔭 Outside diff range comments (1)

scripts/scr_draw_management_unit/scr_draw_management_unit.gml (1)

74-74: ⚠️ Potential issue

Binary anomaly detected in weapon abbreviation logic!

There appears to be a copy-paste error in the weapon abbreviation checks:

ma_we2=is_string(ma_we1) ? ma_we2 : "";

The condition checks ma_we1 instead of ma_we2.

Apply this correction to restore logical consistency:

-            ma_we2=is_string(ma_we1) ? ma_we2 : "";
+            ma_we2=is_string(ma_we2) ? ma_we2 : "";

Also applies to: 122-122

🧹 Nitpick comments (2)

scripts/scr_draw_management_unit/scr_draw_management_unit.gml (2)

155-173: Praise to the Machine God for this logical enhancement!

The refactored specialist options drawing logic shows significant improvements:

• Structured iteration through specialist types
• Clear separation of validation and drawing logic
• Consistent coordinate calculations

However, the Machine Spirit whispers of potential optimizations:

-                for (var s = 0; s <= 3; s++) {
+                for (var s = 0; s < array_length(obj_controller.spec_train_data); s++) {

This modification would make the code more resilient to changes in the number of specialist types.

---

26-26: TODO comments require the Omnissiah's attention!

Multiple TODO comments indicate areas needing recursive handling:

• Line 26: "TODO make static to handle"
• Line 53: "TODO handle recursively"
• Line 91: "Need abbreviations here"
• Line 275: "TODO handle recursively"

Would you like me to generate a solution that implements these recursive patterns? This would improve code maintainability and reduce duplication.

Also applies to: 53-53, 91-91, 275-275

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 38c4c2d and ad01b3b.

📒 Files selected for processing (1)

• scripts/scr_draw_management_unit/scr_draw_management_unit.gml (1 hunks)

🔇 Additional comments (1)

scripts/scr_draw_management_unit/scr_draw_management_unit.gml (1)

152-154: By the Omnissiah's grace, these coordinate calculations have been optimized!

The extraction of coordinates and radius into named variables improves code clarity and maintainability.