fix: index error with roster causing raid/purge issues

[OH296]

Description of changes

• After certain turns, your ship may not be able to be selected in the raid/attack/purge, thus you can not start your attack by these method, but only load and unload repeatly

Reasons for changes

• bug report issue found by user

Related links

• https://discord.com/channels/714022226810372107/1340995217871999046

How have you tested your changes?

• Compile
• New game
• Next turn
• Space Travel
• Ground Battle

[coderabbitai]

📝 Walkthrough

Walkthrough

In this change within the Roster constructor of the scr_roster.gml file, a new variable _ship_index has been introduced. The variable now holds the value retrieved from the _ships array using the current loop index, replacing the direct access via the index s. This change modifies the condition to check obj_ini.ship_carrying[_ship_index] instead of accessing it directly with s, thereby refining the code's readability and structure without affecting its underlying logic or functionality.

Suggested labels

PR: Fix

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

scripts/scr_roster/scr_roster.gml (2)

347-351: Praise be to the Omnissiah! The logic circuit has been optimized.

The introduction of _ship_index variable improves code clarity and prevents potential array index errors by properly mapping the loop counter to actual ship indices. This modification aligns with the sacred patterns of proper array traversal.

Consider further optimization by applying this sacred pattern:

-        var _ship_index;
-        for (var s=0;s<array_length(_ships);s++){
-            _ship_index = _ships[s];
-            if (obj_ini.ship_carrying[_ship_index]>0){
-                new_ship_button(obj_ini.ship[_ship_index],_ship_index);
+        for (var _ship_index of _ships){
+            if (obj_ini.ship_carrying[_ship_index]>0){
+                new_ship_button(obj_ini.ship[_ship_index],_ship_index);

This modification employs the more efficient for...of loop construct, reducing cognitive overhead and potential for indexing errors while maintaining the Machine Spirit's intended functionality.

---

747-749: By the grace of the Machine God, an unimplemented feature has been detected.

The TODO comment indicates that the STC bonus for ranged vehicle weapons remains unimplemented. This missing functionality could impact vehicle combat effectiveness.

Would you like me to generate an implementation for the STC bonus system for ranged vehicle weapons? The Omnissiah's wisdom guides us in such matters.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a44b175 and f379b49.

📒 Files selected for processing (1)

• scripts/scr_roster/scr_roster.gml (1 hunks)