feat: Chapter traits #6

[KRdaMystic]

Description of changes

• Adds 2 new starting traits and 3 specialist traits Serpents Delight, Enduring Angels, Weakened Apothecarion, Small Reclusiam, and Barren Librarius

Reasons for changes

• Continuing to flesh out the trait system with new additions

How have you tested your changes?

• Compile
• New game
• Next turn
• Space Travel
• Ground Battle

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[EttyKitty]

@KRdaMystic, I'll postpone merging this, as I still don't get the consensus about tiny traits.

I was about to merge it, thinking "eh, we already have a bunch of tiny, inconsequential traits, might as well" but then paused.

[OH296]

@KRdaMystic, I'll postpone merging this, as I still don't get the consensus about tiny traits.

I was about to merge it, thinking "eh, we already have a bunch of tiny, inconsequential traits, might as well" but then paused.

Personally i'm in the live and let live category over here, i see no issues here that couldn;t be easily just rolled back if someone really took issue

[KRdaMystic]

I was about to merge it, thinking "eh, we already have a bunch of tiny, inconsequential traits, might as well" but then paused.

I get what you mean these were at the behest of Van originally so I'm impartial for the most part, but the chaplain and Apothecary disadvantages do hinder the player pretty heavily with the addition of the malus traits. But do whatever you think is best and I can adjust from there

[MCPO-Spartan-117]

I clicked review by accident, ignore.

[EttyKitty]

i see no issues here that couldn;t be easily just rolled back if someone really took issue.

yeah, I agree. we're already far into the silly trait designs. no point in trying to be perfect at this point.

[Blogaugis]

TODO: make trait costs nice, round 0s, rather than 5s.

[OH296]

TODO: make trait costs nice, round 0s, rather than 5s.

Why though i assume most people have enough education to do 5 + 5

[Blogaugis]

Why though i assume most people have enough education to do 5 + 5

Because it bothers me to search for a missing trait with 5. Or leave the points filled to 85 or 95.