fix: Enhanced Item Accessibility and Progression #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update introduces a significant overhaul to the forge system, focusing on providing players with greater access to previously unavailable weapons, equipment, and vehicle upgrades, while also improving the overall progression and item availability. **Key Changes:** * **Expanded Crafting Options:** Previously unobtainable items are now craftable within the forge, pending certain research levels and STC unlocks, allowing for a wider array of strategic choices. * **Conditional Forge Costs:** Many items now feature conditional `forge_cost[i]` assignments, based on the player’s research levels, STC unlocks and specific requirements. This creates a more dynamic and engaging crafting system and makes a more natural progression for the player. * **New Item: Boltstorm Gauntlet:** A powerful new close-range option for those who like to enter the fray. * **Heavy Bolter and Storm Bolter Adjustments:** The forge cost for Heavy Bolters and Storm Bolters is now conditional on research progress, with their availability gated behind more demanding requirements, making them more appropriate for the mid-game. * **Stalker Pattern Bolter:** The crafting requirements for this weapon have been clarified and streamlined. * **Infernus Pistol Introduction:** This new flamer based pistol has been added to the armory. * **Incinerator Availability:** The Incinerator is now available for production (pending research), fixing its previously unintended state of being uncraftable. * **Vehicle Component Adjustments:** Many vehicle components now have more appropriate costs and crafting conditions, leading to a better gameplay progression. * **New Vehicle Weaponry:** Numerous vehicle weapons are now unlockable via research and STC unlocks, providing a much larger array of options. * **Improved Tooltips:** The research options now have new tooltips that properly describe their functions, making the tech tree easier to navigate. * **Vehicle Hangar Cost Impact:** The cost of vehicle components is now dynamically impacted by the size of the player's vehicle hangar. This encourages players to carefully manage their resources. * **Reorganized Bolter Progression**: The bolter tech tree was reorganized to properly follow their lore and power scale, while also unlocking new powerful options as the research is completed. * **Reworked Armour research:** The armour research was also reworked to require specific levels of research and to reflect the lore more accurately. * **STC progression**: The STC technologies now impact a larger array of items, making them have more progression for the player. **Purpose of Changes:** * **Enhanced Player Choice:** This overhaul aims to give players a wider range of options and flexibility, allowing them to customize their playstyle and strategic approach. * **Improved Progression:** The added conditional requirements and the STC progression will make the player journey into the game much more rewarding. * **Clearer Progression:** By gating items behind research and STC unlocks, we create a more compelling sense of progression, encouraging players to explore the full scope of the game's tech tree. **Balance Notes:** * The changes made in this update have been designed to provide more options to the player and are still experimental, so they might be rebalanced in future updates based on feedback and observed game data.
Reviewer's Guide by SourceryThis pull request enhances item accessibility and progression in the game by adding new equipment, adjusting forge costs and research requirements for existing items, and introducing new research options. These changes affect various item categories, including equipment, armor, vehicles, and research, aiming to provide players with greater access to previously unavailable items and improve the overall progression system. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @Frost-bit-jpg - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider cleaning up indentation inconsistencies throughout the file (e.g. mixed tabs/spaces and varying indent levels)
- There are several repeated patterns like
forge_cost[i] = X*player_hangerthat could be extracted into helper functions to reduce code duplication
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Frost-bit-jpg
changed the title
Frost-bit-jpg
changed the title
|
@sourcery-ai review |
This pull request enables players to equip Rhinos with Hunter-Killer Missiles. Previously, the option to equip this system was unavailable.
This change fixes a typo with recruitment causing scouts to always have 10 corruption that cannot be reduced regardless of the training method.
fix: corruption for new recruits
There was a problem hiding this comment.
Hey @Frost-bit-jpg - I've reviewed your changes - here's some feedback:
Overall Comments:
- Review the use of assignment operators in conditions (e.g., 'if (rene = 1)') to ensure you intended assignment and not comparison.
- Remove or clarify commented-out code sections (such as the Executioner Power Axe block) to improve maintainability.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
OH296
requested changes
Feb 9, 2025
|
i'm vaguely concerned as i mentioned before on the discord that this work (being rather substantial) was not done in conjunction with https://github.com/Adeptus-Dominus/ChapterMaster/pull/425/files. Not the end of the world but just trying to consider how to rationalise the two. e.g push this through or merge this work and get the main rework going. Other wise this or could be considered doubling down on a very flawed system |
|
Well the idea is that since the overhaul work would take potentially more time, the idea is this would serve as temporary place holder and experiment to some ideas around forge prices balance. I did take your concern in mind and discussed the matter before proceeding. |
|
I'm also rather concerned to work on the newer system and potentially cause some issues with the logic flaw. |
whelp no issue, as long as your happy, |
OH296
approved these changes
Feb 10, 2025
|
@sourcery-ai review |
There was a problem hiding this comment.
Hey @Frost-bit-jpg - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider using constants for item names and research names to avoid typos and improve maintainability.
- It looks like you're using a lot of hardcoded values for costs and research requirements; consider using a data-driven approach to make these more configurable.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟡 Review instructions: 2 issues found
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
EttyKitty
reviewed
Feb 10, 2025
MCPO-Spartan-117
suggested changes
Feb 11, 2025
|
@sourcery-ai review |
There was a problem hiding this comment.
Hey @Frost-bit-jpg - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider using constants for item names to avoid typos and improve maintainability.
- It looks like you're using a lot of hardcoded values; consider using data tables or external configuration files.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟡 Review instructions: 2 issues found
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
5 tasks
5 tasks
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughThe changes update the item handling logic within the Possibly related PRs
Suggested labels
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update introduces a significant overhaul to the forge system, focusing on providing players with greater access to previously unavailable weapons, equipment, and vehicle upgrades, while also improving the overall progression and item availability.
Description of changes
Reasons for changes
Related links
How have you tested your changes?