Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Redundant check causing early end game #418

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

OH296
Copy link
Collaborator

@OH296 OH296 commented Jan 13, 2025

Description of changes

  • causing an end game unintentionally

Reasons for changes

  • not good

Related links

How have you tested your changes?

  • Compile
  • New game
  • Next turn
  • Space Travel
  • Ground Battle

Summary by Sourcery

Bug Fixes:

  • Remove the redundant check for the absence of Chapter Masters, which was causing the game to end prematurely.

Copy link
Contributor

sourcery-ai bot commented Jan 13, 2025

🧙 Sourcery has finished reviewing your pull request!


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions github-actions bot added the PR: Fix This is a fix for a bug label Jan 13, 2025
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @OH296 - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Please provide a more detailed PR description explaining what was causing the early game end and why these changes fix it. Include specifics about the redundant check that was removed and how it was causing problems.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@EttyKitty EttyKitty added the PR: Backport Needs to be backported to stable label Jan 13, 2025
@EttyKitty EttyKitty changed the title fix: redundant check causing early end game fix: Redundant check causing early end game Jan 13, 2025
@EttyKitty EttyKitty merged commit c5e145b into Adeptus-Dominus:main Jan 13, 2025
6 checks passed
OH296 added a commit to OH296/ChapterMaster that referenced this pull request Jan 14, 2025
@EttyKitty EttyKitty removed the PR: Backport Needs to be backported to stable label Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Fix This is a fix for a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants