Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove "Power Weapon" from the player side #411

Merged
merged 1 commit into from
Jan 12, 2025

Conversation

EttyKitty
Copy link
Collaborator

@EttyKitty EttyKitty commented Jan 12, 2025

Description of changes

  • Remove "Power Weapon" from appearing at player side completely.

Reasons for changes

  • It's a rudimentary item, that is, from what I see, is used for enemies, to simulate some random power weapon type.

Related links

How have you tested your changes?

  • Compile
  • New game
  • Next turn
  • Space Travel
  • Ground Battle

Summary by Sourcery

Remove "Power Weapon" from player inventory and replace it with "Power Sword".

New Features:

  • Introduce "Power Sword" as a new weapon.

Tests:

  • Test new game functionality.

Copy link
Contributor

sourcery-ai bot commented Jan 12, 2025

Reviewer's Guide by Sourcery

This PR removes the "Power Weapon" from the player side. It updates the weapon initialization logic, removes the weapon from the item list, and updates the UI to reflect these changes.

File-Level Changes

Change Details Files
Removed "Power Weapon" from player-side logic
  • Removed conditional check for "Power Weapon" in Alarm_5 script
objects/obj_controller/Alarm_5.gml
Replaced "Power Weapon" with "Power Sword" in item initialization
  • Replaced "Power Weapon" with "Power Sword" in the item list
scripts/scr_initialize_custom/scr_initialize_custom.gml
Removed "Power Weapon" from weapon descriptions
  • Commented out the description for "Power Weapon"
scripts/scr_weapon/scr_weapon.gml
Removed "Power Weapon" from UI display
  • Removed "Power Weapon" from the weapon sprite map
scripts/scr_ui_display_weapons/scr_ui_display_weapons.gml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions github-actions bot added the PR: Feature Adds something new label Jan 12, 2025
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @EttyKitty - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Please remove the commented-out Power Weapon description in scr_weapon.gml since this item is being removed entirely.
  • The changes touch core weapon mechanics - please complete testing for Next Turn, Space Travel, and especially Ground Battle scenarios before this can be merged.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@OH296
Copy link
Collaborator

OH296 commented Jan 12, 2025

should this not go to stable candidate? we'll put this in immediate hotfix/10.1 release won't we?

@OH296 OH296 merged commit e1b5f41 into Adeptus-Dominus:main Jan 12, 2025
3 checks passed
OH296 pushed a commit to OH296/ChapterMaster that referenced this pull request Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Feature Adds something new
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants