From 0ffb4b0427d77e1b845bb52ee4ce54cdaf43fdd8 Mon Sep 17 00:00:00 2001
From: Nelsonh <Humes101@gmail.com>
Date: Fri, 10 Jan 2025 22:38:52 +0000
Subject: [PATCH 1/3] add fail safes to stop going over technical limit of
 ships

---
 .../scr_player_fleet_functions.gml               | 16 +++++++++++-----
 1 file changed, 11 insertions(+), 5 deletions(-)

diff --git a/scripts/scr_player_fleet_functions/scr_player_fleet_functions.gml b/scripts/scr_player_fleet_functions/scr_player_fleet_functions.gml
index 19e0ae781..ee5f8d81b 100644
--- a/scripts/scr_player_fleet_functions/scr_player_fleet_functions.gml
+++ b/scripts/scr_player_fleet_functions/scr_player_fleet_functions.gml
@@ -164,6 +164,7 @@ function find_and_move_ship_between_fleets(out_fleet, in_fleet, index){
 function merge_player_fleets(main_fleet, merge_fleet){
 	var _merge_ships = fleet_full_ship_array(merge_fleet);
 	for (var i=0;i<array_length(_merge_ships);i++){
+		if (_merge_ships[i]<array_length(obj_ini.ship));
 		find_and_move_ship_between_fleets(merge_fleet, main_fleet, _merge_ships[i]);
 	}
 	main_fleet.alarm[7]=1;
@@ -458,26 +459,31 @@ function player_retreat_from_fleet_combat(){
 function fleet_full_ship_array(fleet="none", exclude_capitals=false, exclude_frigates = false, exclude_escorts = false){
 	var all_ships = [];
 	var i;
+	var _ship_count = array_length(obj_ini.ship);
 	if (fleet=="none"){
 		if (!exclude_capitals){
 			for (i=0; i<array_length(capital_num);i++){
 
-				array_push(all_ships, capital_num[i]);
+				if (capital_num[i]<_ship_count){
+					array_push(all_ships, capital_num[i]);
+				}
 
 			}
 		}
 		if (!exclude_frigates){
 			for (i=0; i<array_length(frigate_num);i++){
 
-				array_push(all_ships, frigate_num[i]);
+				if (frigate_num[i]<_ship_count){
+					array_push(all_ships, frigate_num[i]);
+				}
 
 			}
 		}
 		if (!exclude_escorts){
 			for (i=0; i<array_length(escort_num);i++){
-
-				array_push(all_ships, escort_num[i]);
-
+				if (escort_num[i]<_ship_count){
+					array_push(all_ships, escort_num[i]);
+				}
 			}
 		}			
 	} else {

From fb4487f0fb97bc7a84ea67a5ad0ea2785f9927fc Mon Sep 17 00:00:00 2001
From: Nelsonh <Humes101@gmail.com>
Date: Fri, 10 Jan 2025 22:52:03 +0000
Subject: [PATCH 2/3] bundle or array issues with killing ships

---
 .../scr_ini_ship_cleanup.gml                   | 18 +++++++++++++-----
 .../scr_player_fleet_functions.gml             |  5 +++--
 2 files changed, 16 insertions(+), 7 deletions(-)

diff --git a/scripts/scr_ini_ship_cleanup/scr_ini_ship_cleanup.gml b/scripts/scr_ini_ship_cleanup/scr_ini_ship_cleanup.gml
index c5a106207..d15fe0e5f 100644
--- a/scripts/scr_ini_ship_cleanup/scr_ini_ship_cleanup.gml
+++ b/scripts/scr_ini_ship_cleanup/scr_ini_ship_cleanup.gml
@@ -7,17 +7,25 @@ function scr_kill_ship(index){
 			for (var co=0;co<=companies;co++){
 				for (var i=0;i<array_length(name[co]);i++){
 					_unit = fetch_unit([co,i]);
-					if (_unit.ship_location == index){
-						if (!irandom(_unit.luck)-3){
-							scr_kill_unit(_unit.company, _unit.marine_number);
+					if (_unit.ship_location>-1){
+						if (_unit.ship_location == index){
+							if (!irandom(_unit.luck)-3){
+								scr_kill_unit(_unit.company, _unit.marine_number);
+							} else {
+								array_push(_units_on_ship, _unit);
+							}
 						} else {
-							array_push(_units_on_ship, _unit);
+							if (_unit.ship_location>index){
+								_unit.ship_location--;
+							}
 						}
 					}
 				}
-				for (var i=0;i<array_length(veh_role);i++){
+				for (var i=0;i<array_length(veh_role[co]);i++){
 					if (veh_lid[co][i]==index){
 						reset_vehicle_variable_arrays(co, i);
+					} else if (veh_lid[co][i]>index){
+						veh_lid[co][i]--;
 					}
 				}
 			}
diff --git a/scripts/scr_player_fleet_functions/scr_player_fleet_functions.gml b/scripts/scr_player_fleet_functions/scr_player_fleet_functions.gml
index ee5f8d81b..689e0bb0b 100644
--- a/scripts/scr_player_fleet_functions/scr_player_fleet_functions.gml
+++ b/scripts/scr_player_fleet_functions/scr_player_fleet_functions.gml
@@ -164,8 +164,9 @@ function find_and_move_ship_between_fleets(out_fleet, in_fleet, index){
 function merge_player_fleets(main_fleet, merge_fleet){
 	var _merge_ships = fleet_full_ship_array(merge_fleet);
 	for (var i=0;i<array_length(_merge_ships);i++){
-		if (_merge_ships[i]<array_length(obj_ini.ship));
-		find_and_move_ship_between_fleets(merge_fleet, main_fleet, _merge_ships[i]);
+		if (_merge_ships[i]<array_length(obj_ini.ship)){
+			find_and_move_ship_between_fleets(merge_fleet, main_fleet, _merge_ships[i]);
+		}
 	}
 	main_fleet.alarm[7]=1;
     if (instance_exists(obj_fleet_select)){

From 4e44a568f57962eed29f06057d05c0ec411cc90b Mon Sep 17 00:00:00 2001
From: Nelsonh <Humes101@gmail.com>
Date: Fri, 10 Jan 2025 23:06:12 +0000
Subject: [PATCH 3/3] edit to luck check

---
 scripts/scr_ini_ship_cleanup/scr_ini_ship_cleanup.gml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/scr_ini_ship_cleanup/scr_ini_ship_cleanup.gml b/scripts/scr_ini_ship_cleanup/scr_ini_ship_cleanup.gml
index d15fe0e5f..898ae7766 100644
--- a/scripts/scr_ini_ship_cleanup/scr_ini_ship_cleanup.gml
+++ b/scripts/scr_ini_ship_cleanup/scr_ini_ship_cleanup.gml
@@ -9,7 +9,7 @@ function scr_kill_ship(index){
 					_unit = fetch_unit([co,i]);
 					if (_unit.ship_location>-1){
 						if (_unit.ship_location == index){
-							if (!irandom(_unit.luck)-3){
+							if (!(irandom(_unit.luck)-3)){
 								scr_kill_unit(_unit.company, _unit.marine_number);
 							} else {
 								array_push(_units_on_ship, _unit);