fix: Vehicle spawning

[OH296]

Description of changes

• Removed use of 0 index not normally used in vehicle arrays causing vehicles to not spawn as 0 index was exiting logic

Reasons for changes

• vehicles could not be made or spawned
• bug reported

Related links

• https://discord.com/channels/714022226810372107/1120687959365128243/threads/1325950499362439330

How have you tested your changes?

• Compile
• New game
• Next turn
• Space Travel
• Ground Battle

Summary by Sourcery

Bug Fixes:

• Fixed an issue that prevented vehicles from spawning.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request fixes a bug that prevented vehicles from spawning. The bug was caused by the use of a 0 index in the vehicle arrays, which is not normally used. The fix changes the start index of the loop from 0 to 1.

File-Level Changes

Change	Details	Files
Start vehicle array indexing from 1	Changed the loop start index from 0 to 1 to avoid using the 0 index in the vehicle arrays. Used array access instead of array accessor in the condition check inside the loop	scripts/scr_add_vehicle/scr_add_vehicle.gml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @OH296 - I've reviewed your changes - here's some feedback:

Overall Comments:

• Starting array iteration from index 1 instead of 0 seems unusual and could lead to confusion. Could you explain why index 0 needs to be skipped? There might be a better solution that maintains conventional 0-based array indexing.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}