-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
revert: Armour randomization by default #389
revert: Armour randomization by default #389
Conversation
Reviewer's Guide by SourceryThis PR reverts the changes introduced in #368, which attempted to fix Terminator Armour randomization but introduced bugs. The revert restores the previous armor assignment logic. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
c19f863
to
798bce8
Compare
@sourcery-ai review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @EttyKitty - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider extracting the duplicated armor selection logic into a helper function to reduce code duplication and make future maintenance easier.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @EttyKitty - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider extracting the repeated armor selection logic into a helper function to reduce code duplication. The same pattern appears multiple times and could be consolidated.
- There's a debug message that was uncommented (
show_debug_message($"chap terminators {terminator}")
). This should probably remain commented out in production code.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Description of changes
Reasons for changes
Related links
How have you tested your changes?
Summary by Sourcery
Bug Fixes: