refactor: Wrap a ton of stuff into try/catch and format #381

EttyKitty · 2025-01-05T10:14:48Z

Description of changes

Wrap all things from critical bug reports into try/catch.
Format all the same things with the Gobo formatter.

Reasons for changes

Wraps are to prevent hard crashes.
Formatting is to improve visual clarity of code.

How have you tested your changes?

Summary by Sourcery

Wrap critical code sections in try/catch blocks and apply consistent code formatting.

Bug Fixes:

Prevent hard crashes by wrapping critical code sections in try/catch blocks.

Enhancements:

Improve code readability through consistent formatting using the Gobo formatter.

Summary by Sourcery

Wrap exception handling around code related to critical bug reports and format it using the Gobo formatter.

Bug Fixes:

Prevent hard crashes by wrapping critical code sections in try/catch blocks.

Enhancements:

Improve code readability through consistent formatting using the Gobo formatter.

It was hard crashing the game otherwise.

sourcery-ai · 2025-01-05T10:14:52Z

Reviewer's Guide by Sourcery

This pull request implements crash prevention and code formatting improvements. The changes involve wrapping code sections in try/catch blocks and applying the Gobo formatter.

File-Level Changes

Change	Details	Files
Wrapped code sections related to critical bug reports in try/catch blocks to prevent hard crashes.	Added try/catch blocks around various code sections to handle potential errors and prevent crashes. Implemented exception handling to gracefully exit to the main menu in case of unexpected errors during specific operations. Ensured that critical code blocks are protected by error handling mechanisms to maintain game stability.	`objects/obj_creation/Draw_0.gml` `objects/obj_popup/Step_0.gml` `objects/obj_drop_select/Draw_64.gml`
Formatted the code using the Gobo formatter to enhance readability and maintain consistency.	Applied the Gobo formatter to improve code style and consistency. Reformatted code blocks for better visual clarity and maintainability. Standardized code formatting to adhere to project guidelines and improve readability.	`objects/obj_creation/Draw_0.gml` `objects/obj_popup/Step_0.gml` `scripts/NameGenerator/NameGenerator.gml`

Tips and commands

Interacting with Sourcery

Trigger a new review: Comment @sourcery-ai review on the pull request.
Continue discussions: Reply directly to Sourcery's review comments.
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it.
Generate a pull request title: Write @sourcery-ai anywhere in the pull
request title to generate a title at any time.
Generate a pull request summary: Write @sourcery-ai summary anywhere in
the pull request body to generate a PR summary at any time. You can also use
this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others.
Change the review language.
Add, remove or edit custom review instructions.
Adjust other review settings.

Getting Help

Contact our support team for questions or feedback.
Visit our documentation for detailed guides and information.
Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

sourcery-ai

Hey @EttyKitty - I've reviewed your changes - here's some feedback:

Overall Comments:

Consider adding error logging within the catch blocks to help diagnose issues in production

Here's what I looked at during the review

🟡 General issues: 1 issue found
🟢 Security: all looks good
🟢 Testing: all looks good
🟢 Complexity: all looks good
🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

objects/obj_popup/Step_0.gml

scripts/scr_add_vehicle/scr_add_vehicle.gml

OH296 · 2025-01-05T17:35:02Z

@sourcery-ai review

sourcery-ai

Hey @EttyKitty - I've reviewed your changes - here's some feedback:

Overall Comments:

While adding error handling is a good improvement, consider implementing more granular error handling for different failure cases rather than just wrapping everything in try/catch and destroying instances. Also consider adding proper error logging before destroying instances to aid debugging.

Here's what I looked at during the review

🟡 General issues: 1 issue found
🟢 Security: all looks good
🟢 Testing: all looks good
🟢 Complexity: all looks good
🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

objects/obj_popup/Step_0.gml

EttyKitty · 2025-01-05T18:20:08Z

@sourcery-ai review

sourcery-ai

Hey @EttyKitty - I've reviewed your changes - here's some feedback:

Overall Comments:

Consider handling specific exceptions instead of using blanket try/catch blocks to improve debugging and ensure only expected exceptions are caught.
Ensure that exceptions are logged or handled appropriately in the catch blocks to aid in diagnosing issues.
Consider adding automated tests to cover the critical paths wrapped in try/catch to ensure the changes don't introduce new bugs.

Here's what I looked at during the review

🟢 General issues: all looks good
🟢 Security: all looks good
🟢 Testing: all looks good
🟢 Complexity: all looks good
🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

OH296 · 2025-01-05T17:52:44Z

scripts/scr_ancient_ruins/scr_ancient_ruins.gml

+		pip.option3 = "Return your marines to the ship.";
+		pip.image = "ancient_ruins";
+	} catch (_exception) {
+		handle_exception(_exception);


Suggested change

handle_exception(_exception);

handle_exception(_exception);

instance_destroy();

refactor: Wrap scr_add_vehicle into try/catch and format

274467a

It was hard crashing the game otherwise.

github-actions bot added PR: Refactor Rewriting/restructuring code, while keeping general behaviour PR: Major Coding Big enough to possibly clash with other PRs labels Jan 5, 2025

sourcery-ai bot previously approved these changes Jan 5, 2025

View reviewed changes

objects/obj_popup/Step_0.gml Show resolved Hide resolved

EttyKitty requested a review from OH296 January 5, 2025 10:34

EttyKitty added 9 commits January 5, 2025 19:07

refactor: Wrap popup step_0 into try/catch and format

ceb1218

refactor: Wrap drop_select draw_64 into try/catch and format

2eea287

refactor: Wrap scr_ancient_ruins into try/catch and format

6734a9c

refactor: Wrap scr_restart_variables into try/catch and format

7ec4382

refactor: Wrap fleet_select draw_64 into try/catch and format

7a0bc5a

refactor: Wrap NameGenerator into try/catch and format

7d68e23

refactor: Wrap creation draw_0 into try/catch and format

05363e5

refactor: Wrap popup draw_0 into try/catch and format

f936b96

Proper exception handling

ce573be

EttyKitty dismissed sourcery-ai[bot]’s stale review via ce573be January 5, 2025 16:13

EttyKitty force-pushed the pr/try-catch-wraps branch from 729f408 to ce573be Compare January 5, 2025 16:13

OH296 previously approved these changes Jan 5, 2025

View reviewed changes

scripts/scr_add_vehicle/scr_add_vehicle.gml Show resolved Hide resolved

OH296 dismissed their stale review via 3984b88 January 5, 2025 17:34

EttyKitty changed the title ~~refactor: Wrap scr_add_vehicle into try/catch and format~~ refactor: Wrap a ton of stuff into try/catch and format Jan 5, 2025

sourcery-ai bot previously approved these changes Jan 5, 2025

View reviewed changes

objects/obj_popup/Step_0.gml Show resolved Hide resolved

EttyKitty added PR: Code Style Not affecting how code works, only visual changes PR: Fix This is a fix for a bug labels Jan 5, 2025

EttyKitty dismissed sourcery-ai[bot]’s stale review via ce573be January 5, 2025 18:19

EttyKitty force-pushed the pr/try-catch-wraps branch from 3984b88 to ce573be Compare January 5, 2025 18:19

EttyKitty removed the PR: Fix This is a fix for a bug label Jan 5, 2025

sourcery-ai bot approved these changes Jan 5, 2025

View reviewed changes

EttyKitty merged commit b5be3d8 into Adeptus-Dominus:release/0.10.0.0 Jan 5, 2025
2 checks passed

EttyKitty deleted the pr/try-catch-wraps branch January 5, 2025 18:23

OH296 reviewed Jan 5, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: Wrap a ton of stuff into try/catch and format #381

refactor: Wrap a ton of stuff into try/catch and format #381

EttyKitty commented Jan 5, 2025 •

edited by sourcery-ai bot

Loading

sourcery-ai bot commented Jan 5, 2025 •

edited

Loading

Interacting with Sourcery

Customizing Your Experience

Getting Help

sourcery-ai bot left a comment

OH296 commented Jan 5, 2025

sourcery-ai bot left a comment

EttyKitty commented Jan 5, 2025

sourcery-ai bot left a comment

OH296 Jan 5, 2025 •

edited

Loading

	handle_exception(_exception);
	handle_exception(_exception);
	instance_destroy();

refactor: Wrap a ton of stuff into try/catch and format #381

refactor: Wrap a ton of stuff into try/catch and format #381

Conversation

EttyKitty commented Jan 5, 2025 • edited by sourcery-ai bot Loading

Description of changes

Reasons for changes

Related links

How have you tested your changes?

Summary by Sourcery

Summary by Sourcery

sourcery-ai bot commented Jan 5, 2025 • edited Loading

Reviewer's Guide by Sourcery

File-Level Changes

Interacting with Sourcery

Customizing Your Experience

Getting Help

sourcery-ai bot left a comment

Choose a reason for hiding this comment

OH296 commented Jan 5, 2025

sourcery-ai bot left a comment

Choose a reason for hiding this comment

EttyKitty commented Jan 5, 2025

sourcery-ai bot left a comment

Choose a reason for hiding this comment

OH296 Jan 5, 2025 • edited Loading

Choose a reason for hiding this comment

EttyKitty commented Jan 5, 2025 •

edited by sourcery-ai bot

Loading

sourcery-ai bot commented Jan 5, 2025 •

edited

Loading

OH296 Jan 5, 2025 •

edited

Loading