Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tidy up the aspirant trial display on chapter creation slides #377

Conversation

VanWeapon
Copy link
Contributor

@VanWeapon VanWeapon commented Jan 4, 2025

Description of changes

  • UI bugfixes on chapter creation

Reasons for changes

  • Fixes overflowing text and extra debug detail displayed to the player

Related links

  • n/a

Summary by Sourcery

Bug Fixes:

  • Fixed overflowing text and removed extra debug details displayed to the player.

Copy link
Contributor

sourcery-ai bot commented Jan 4, 2025

Reviewer's Guide by Sourcery

This PR implements UI bugfixes on the chapter creation screen, addressing issues with overflowing text and extra debug details displayed to the player. It repositions UI elements related to aspirant trials and removes the display of stat differences from the trial bonus string.

File-Level Changes

Change Details Files
Reposition UI elements related to aspirant trials
  • Updated coordinates for drawing the "Aspirant Trial" text and the trial name.
  • Adjusted the hitbox for the aspirant trial tooltip.
  • Modified the position of the arrow sprites used for changing aspirant trials.
  • Updated the coordinates for drawing the trial bonus information using draw_text_ext_transformed.
  • Changed the width parameter in draw_text_ext_transformed to prevent text overflow.
objects/obj_creation/Draw_0.gml
Remove display of stat differences from trial bonus string
  • Commented out the code block that adds stat differences to the bonus string in the scr_compile_trial_bonus_string function.
  • Added a space after "Favoured Traits:" and "Dis-Favoured Traits:" in the scr_compile_trial_bonus_string function to improve readability.
  • Capitalized "Years" in the training time string within the same function.
scripts/scr_recruit_data/scr_recruit_data.gml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions github-actions bot added the PR: Fix This is a fix for a bug label Jan 4, 2025
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @VanWeapon - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@EttyKitty EttyKitty merged commit 3f5a917 into Adeptus-Dominus:release/0.10.0.0 Jan 4, 2025
3 checks passed
KRdaMystic pushed a commit to KRdaMystic/ChapterMaster that referenced this pull request Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Fix This is a fix for a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants