Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Planet and faction sprites displaying wrong sprites #372

Merged

Conversation

OH296
Copy link
Collaborator

@OH296 OH296 commented Jan 3, 2025

Description of changes

  • changes sprite call method for star faction owner symbol
  • add previously placeholder frame in planet sprite set

Reasons for changes

  • systems were displaying wrong owner sprite
  • planets were displaying incorrect sprites

Summary by Sourcery

Add a missing frame to the planet sprite sheet and fix the display of faction sprites for stars.

Bug Fixes:

  • Fixed an issue where stars were displaying the wrong owner sprite.
  • Fixed an issue where planets were displaying incorrect sprites.

Copy link
Contributor

sourcery-ai bot commented Jan 3, 2025

Reviewer's Guide by Sourcery

This pull request fixes an issue with incorrect sprite display for planets and faction symbols. It adds a missing frame to the planet sprite sheet and corrects the method used to call faction sprites, ensuring the correct sprites are displayed.

File-Level Changes

Change Details Files
Added a missing frame to the planet sprite sheet and updated the animation length.
  • Added a new frame to the beginning of the sprite sheet.
  • Increased the animation length from 20 to 21 to accommodate the new frame.
  • Shifted subsequent frames in the animation timeline by one frame to accommodate the new frame.
sprites/spr_planets/spr_planets.yy
Corrected the faction sprite indexing to display the correct symbol.
  • Removed the addition of 1 to the owner index when determining the faction sprite to display.
  • Replaced direct sprite calls with a consistent draw_sprite_ext call using the corrected index.
objects/obj_star/Draw_0.gml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions github-actions bot added PR: Sprites Changes to sprites/images PR: Fix This is a fix for a bug labels Jan 3, 2025
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @OH296 - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider expanding the commit message to better explain the technical changes made - specifically the sprite caching removal and frame index adjustments. This helps future maintainers understand the rationale.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@OH296 OH296 merged commit cd4ce27 into Adeptus-Dominus:release/0.10.0.0 Jan 3, 2025
3 checks passed
KRdaMystic pushed a commit to KRdaMystic/ChapterMaster that referenced this pull request Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Fix This is a fix for a bug PR: Sprites Changes to sprites/images
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant