fix: ai_a script increase efficiency and error handling to find unresolved crash

[OH296]

• increase efficiency of calling of ai scripts in obj_Star step

• deprecate try_And_Report_loop for try{}catch(){handle_exception}

• improves checks for "Shitty Luck" in ai_a

• aim is to make https://discord.com/channels/714022226810372107/1320239221830844546 this easier to find and resolve

Summary by Sourcery

Improve the efficiency and error handling of the AI scripts for the "obj_Star" step. Replace the "try_And_Report_loop" with a try-catch block. Improve the checks for "Shitty Luck" in "ai_a".

New Features:

• Implement error handling for AI scripts.

Enhancements:

• Improve the efficiency of calling AI scripts.

Tests:

• Update tests for AI scripts.

[sourcery-ai]

Reviewer's Guide by Sourcery

This PR improves the efficiency of the AI scripts in the obj_Star step event and replaces the try_And_Report_loop function with a try-catch block for improved error handling. It also refactors the "Shitty Luck" check in the ai_a script.

File-Level Changes

Change	Details	Files
Improved efficiency of AI scripts by decrementing AI counters before checking if they are zero.	Decrementing ai_* variables before checking their values in the obj_star's Step_0 event. Removed redundant checks and streamlined the logic for updating AI states.	objects/obj_star/Step_0.gml
Replaced the deprecated try_And_Report_loop function with a try-catch block for better error handling.	Replaced calls to try_and_report_loop with try...catch blocks in the obj_star's Step_0 event. This change improves error handling and provides more specific error messages.	objects/obj_star/Step_0.gml
Improved the "Shitty Luck" check in the ai_a script.	Replaced the manual check for "Shitty Luck" with a call to the scr_has_disadv function. Simplified the logic for determining the chapter_asset_discovery value based on the presence of "Shitty Luck". Added delete _planet_data to clean up temporary variables.	scripts/scr_enemy_ai_a/scr_enemy_ai_a.gml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @OH296 - I've reviewed your changes and they look great!

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}