fix: Roll armor works on termies again and is improved

[EttyKitty]

Description of changes

• Removed a bunch of debug lines that were slowing loading.
• Moved all armor pick handling into the proper function.
• Modified said function to account for "Crafters" trait.
• Refactored said function a bit.
• Renamed roll_armour into random_update_armour.

Reasons for changes

• Due to the chapter data rework, terminator armor randomization was not working.

Related links

Summary by Sourcery

Fix terminator armor randomization and improve armor selection logic. Remove debug logs.

Bug Fixes:

• Fix terminator armor randomization caused by chapter data rework.

Enhancements:

• Improve armor selection logic.
• Consolidate armor picking logic into a dedicated function.

[sourcery-ai]

Reviewer's Guide by Sourcery

This PR fixes terminator armor rolling and refactors the armor rolling logic.

File-Level Changes

Change	Details	Files
Refactored armor rolling logic into the scr_marine_spawn_armour function and renamed it to random_update_armour.	Moved all armor pick handling into scr_marine_spawn_armour. Added handling for the "Crafters" trait to influence armor selection. Renamed roll_armour to random_update_armour. Refactored the logic within the function to accommodate these changes.	scripts/scr_unit_spawn_functions/scr_unit_spawn_functions.gml scripts/scr_marine_struct/scr_marine_struct.gml
Removed debug logging statements.	Removed calls to show_debug_message, debugl, and debug string formatting.	scripts/scr_initialize_custom/scr_initialize_custom.gml scripts/scr_complex_colour_kit/scr_complex_colour_kit.gml
Updated unit creation to use the new armor rolling logic.	Modified add_unit_to_company to call random_update_armour for armor assignment. Removed manual armor assignment based on the "Crafters" trait and terminator availability.	scripts/scr_initialize_custom/scr_initialize_custom.gml
Updated the scr_marine_game_spawn_constructions function to use the new random_update_armour function.	Replaced the call to roll_armour with random_update_armour.	scripts/scr_unit_spawn_functions/scr_unit_spawn_functions.gml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @EttyKitty - I've reviewed your changes and they look great!

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[VanWeapon]

Nice, looks clean