Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Separate armor heads #367

Merged
merged 1 commit into from
Jan 12, 2025
Merged

Conversation

EttyKitty
Copy link
Collaborator

@EttyKitty EttyKitty commented Jan 2, 2025

Description of changes

  • Separate most armor heads from the body.
  • Rename Tartaros head file into head_variants.
  • Only indomitus is left unseparated, as it's difficult.

Reasons for changes

  • To add a no-helmet option down the line.

Related links

Summary by Sourcery

New Features:

  • Added no-helmet option for several armor sets.

Summary by Sourcery

New Features:

  • Added head variants for several armor sets, allowing for future customization options like no-helmet.

Copy link
Contributor

sourcery-ai bot commented Jan 2, 2025

Reviewer's Guide by Sourcery

This pull request separates the head sprites for several armor sets from their respective body sprites. This change is made in preparation for adding a no-helmet option in the future. The Tartaros head sprite is renamed to head_variants, and the bounding boxes are updated accordingly. The Indomitus armor set is not yet separated due to its complexity.

File-Level Changes

Change Details Files
Separated armor head sprites from body sprites
  • Created new head variant sprites for MK3, MK4, MK6, and MK7 armor sets.
  • Renamed spr_tartaros_head to spr_tartaros_head_variants.
  • Updated the get_complex_set function to include the new head variant sprites.
  • Adjusted bounding boxes for the affected sprites.
sprites/spr_mk3_head_variants/spr_mk3_head_variants.yy
sprites/spr_mk4_head_variants/spr_mk4_head_variants.yy
sprites/spr_mk6_head_variants/spr_mk6_head_variants.yy
sprites/spr_mk7_head_variants/spr_mk7_head_variants.yy
sprites/spr_tartaros_head/spr_tartaros_head.yy
sprites/spr_tartaros_head_variants/spr_tartaros_head_variants.yy
scripts/scr_draw_unit_image/scr_draw_unit_image.gml
Updated complex armor sprites
  • Adjusted bounding boxes for the complex armor sprites to accommodate the separated head sprites.
sprites/spr_mk3_complex/spr_mk3_complex.yy
sprites/spr_mk4_complex/spr_mk4_complex.yy
sprites/spr_mk6_complex/spr_mk6_complex.yy
sprites/spr_mk7_complex/spr_mk7_complex.yy

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions github-actions bot added the PR: Sprites Changes to sprites/images label Jan 2, 2025
@EttyKitty EttyKitty changed the title Pr/separate-heads feat: Separate armor heads Jan 2, 2025
sourcery-ai[bot]
sourcery-ai bot previously approved these changes Jan 2, 2025
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @EttyKitty - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@OH296 OH296 added this to the v0.10.1 milestone Jan 3, 2025
@OH296 OH296 changed the base branch from release/0.10.0.0 to main January 12, 2025 21:26
@OH296 OH296 dismissed sourcery-ai[bot]’s stale review January 12, 2025 21:26

The base branch was changed.

@OH296
Copy link
Collaborator

OH296 commented Jan 12, 2025

@sourcery-ai review

@OH296 OH296 enabled auto-merge (squash) January 12, 2025 21:27
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @EttyKitty - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@OH296 OH296 merged commit 89afaa2 into Adeptus-Dominus:main Jan 12, 2025
5 of 7 checks passed
@EttyKitty EttyKitty added the PR: Chore Does something that does't fit other labels label Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Chore Does something that does't fit other labels PR: Sprites Changes to sprites/images
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants