chore: json file error

[VanWeapon]

Description of changes

• adds a popup error if a malform json file is attempted to be read but can't, e.g. someone edits their chapter save and its no longer valid json.

Reasons for changes

• Provides instant feedback to players that they made a mistake, can be screenshotted for discord bug reports where a tech priest can inform them how to fix

Related links

• https://discord.com/channels/714022226810372107/714027491412410369/1323843628862537802

Summary by Sourcery

Bug Fixes:

• Detect and report malformed JSON files encountered when loading chapter save data.

[sourcery-ai]

Reviewer's Guide by Sourcery

This PR implements error handling for JSON file parsing. When a malformed JSON file is encountered, a popup error message is displayed to the user. This provides immediate feedback and facilitates bug reporting.

File-Level Changes

Change	Details	Files
Added error handling for malformed JSON files.	Logs a debug message with the parsing error. Displays a popup error message to the player with details about the parsing failure, including the file path and the full error message. Also, it instructs the player to check the file for typos or formatting errors. Returns an empty object instead of incomplete or invalid data to prevent further issues.	scripts/JsonFileListLoader/JsonFileListLoader.gml
No changes in this file. This file is likely included due to project settings or build dependencies.		ChapterMaster.yyp

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @VanWeapon - I've reviewed your changes and they look great!

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[OH296]

Seems to me like for some reason this has fucked up the diplomacy icon images, their numbers should all relate to their faction enum id's but instead i see the ork icon is 13 when it should be 7 and the inquis is instead 7 amongst other issues

[VanWeapon]

Seems to me like for some reason this has fucked up the diplomacy icon images, their numbers should all relate to their faction enum id's but instead i see the ork icon is 13 when it should be 7 and the inquis is instead 7 amongst other issues

@OH296 From testing #363 it seems to work? I didn't reorder the icon indexes, if you look at diplomacy_icons.png which is what i split from, and count boxes from the left starting at 1, then you get the same ids. There's a light and dark version of each small icon which is why the indexes are off

[OH296]

Seems to me like for some reason this has fucked up the diplomacy icon images, their numbers should all relate to their faction enum id's but instead i see the ork icon is 13 when it should be 7 and the inquis is instead 7 amongst other issues

@OH296 From testing #363 it seems to work? I didn't reorder the icon indexes, if you look at diplomacy_icons.png which is what i split from, and count boxes from the left starting at 1, then you get the same ids. There's a light and dark version of each small icon which is why the indexes are off

Yep, sorry see that now, all is good.

[OH296]

@sourcery-ai review

[sourcery-ai]

Hey @VanWeapon - I've reviewed your changes - here's some feedback:

Overall Comments:

• Consider using 'fix:' instead of 'chore:' in the commit title since this change improves error handling for invalid user input. See the conventional commit types guide linked in the PR template.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}