-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow Tactical Bikers and Marines to sabotage #365
feat: Allow Tactical Bikers and Marines to sabotage #365
Conversation
Reviewer's Guide by SourceryThis pull request implements sabotage missions for Tactical Bikers and Tactical Marines with the Ambushers advantage. It modifies the unit data to include "bike" and "scout" classes, enabling the sabotage mission selection logic to recognize these units. The Ambushers advantage logic is updated to add the "scout" class to Tactical Marines if the advantage is present. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @KRdaMystic - I've reviewed your changes - here's some feedback:
Overall Comments:
- Inconsistent property naming: 'class' vs 'class:' in different parts of the code. Please standardize the property naming convention.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Adds sabotage to the biker squad capabilities.
Allows for Tacticals (Ambushers) to do sabotage missions
dae310a
to
87c6708
Compare
@sourcery-ai review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @KRdaMystic - I've reviewed your changes - here's some feedback:
Overall Comments:
- Missing closing curly brace at the end of scr_initialize_custom.gml
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Description of changes
-Allows Tactical Bikers to do sabotage missions
-Allows Tactical marines to do sabotage missions for chapters with Ambushers
Reasons for changes
-Add more to Lightning warriors and Ambushers to make them more competetive as advantages.
Summary by Sourcery
New Features: