Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow Tactical Bikers and Marines to sabotage #365

Merged
merged 3 commits into from
Jan 1, 2025

Conversation

KRdaMystic
Copy link
Contributor

@KRdaMystic KRdaMystic commented Jan 1, 2025

Description of changes

-Allows Tactical Bikers to do sabotage missions
-Allows Tactical marines to do sabotage missions for chapters with Ambushers

Reasons for changes

-Add more to Lightning warriors and Ambushers to make them more competetive as advantages.

Summary by Sourcery

New Features:

  • Tactical Bikers and Tactical Marines with the "Ambushers" advantage can now perform sabotage missions.

Copy link
Contributor

sourcery-ai bot commented Jan 1, 2025

Reviewer's Guide by Sourcery

This pull request implements sabotage missions for Tactical Bikers and Tactical Marines with the Ambushers advantage. It modifies the unit data to include "bike" and "scout" classes, enabling the sabotage mission selection logic to recognize these units. The Ambushers advantage logic is updated to add the "scout" class to Tactical Marines if the advantage is present.

File-Level Changes

Change Details Files
Added the ability for Tactical Bikers to perform sabotage missions.
  • Added a "bike" class to Tactical Bikers unit data.
  • Included Tactical Bikers with the "bike" class in the sabotage mission selection logic
scripts/scr_initialize_custom/scr_initialize_custom.gml
scripts/scr_company_struct/scr_company_struct.gml
Added the ability for Tactical Marines with the Ambushers advantage to perform sabotage missions.
  • Added logic to include the "scout" class for Tactical Marines if the Ambushers advantage is active.
  • Included Tactical Marines with the "scout" class in the sabotage mission selection logic
scripts/scr_initialize_custom/scr_initialize_custom.gml
scripts/scr_company_struct/scr_company_struct.gml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions github-actions bot added the PR: Feature Adds something new label Jan 1, 2025
@sourcery-ai sourcery-ai bot changed the title feat: Trait buffs @sourcery-ai feat: Allow Tactical Bikers and Marines to sabotage Jan 1, 2025
sourcery-ai[bot]
sourcery-ai bot previously approved these changes Jan 1, 2025
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @KRdaMystic - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Inconsistent property naming: 'class' vs 'class:' in different parts of the code. Please standardize the property naming convention.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

KRdaMystic and others added 3 commits January 1, 2025 15:14
Adds sabotage to the biker squad capabilities.
Allows for Tacticals (Ambushers) to do sabotage missions
@KRdaMystic
Copy link
Contributor Author

@sourcery-ai review

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @KRdaMystic - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Missing closing curly brace at the end of scr_initialize_custom.gml
Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@OH296 OH296 merged commit a57c40d into Adeptus-Dominus:release/0.10.0.0 Jan 1, 2025
1 check passed
@KRdaMystic KRdaMystic deleted the feat/trait_buffs branch January 2, 2025 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Feature Adds something new
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants