Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve Obliterated trait (balance) #364

Merged
merged 1 commit into from
Jan 1, 2025

Conversation

KRdaMystic
Copy link
Contributor

@KRdaMystic KRdaMystic commented Jan 1, 2025

gives obliterated a fighting chance.

Description of changes

-Adds one specialist to each of the offices to avoid inquisition penalties
-Strength points over 5 now count for 10 scouts in place of 5
-removed the siege = 0 from obliterated's block of code

Reasons for changes

  • Making obliterated more playable instead of the current guaranteed traitor declaration by the inquisitor.

Summary by Sourcery

Rebalance the "Obliterated" trait by reducing penalties to specialist counts and increasing the scout bonus for strength points above 5.

Bug Fixes:

  • Reduce the penalties applied to specialist counts for the "Obliterated" trait.

Enhancements:

  • Increase the scout bonus from strength points over 5 for "Obliterated" trait.

gives obliterated a fighting chance.
Copy link
Contributor

sourcery-ai bot commented Jan 1, 2025

Reviewer's Guide by Sourcery

This pull request modifies the \


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions github-actions bot added the PR: Fix This is a fix for a bug label Jan 1, 2025
@sourcery-ai sourcery-ai bot changed the title fix: trait buffs @sourcery-ai feat(balance): Improve Obliterated trait Jan 1, 2025
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @KRdaMystic - I've reviewed your changes - here's some feedback:

Overall Comments:

  • The removal of siege = 0 for the Obliterated trait isn't mentioned in the description. Was this intentional? If so, please document this change in the PR description.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@KRdaMystic KRdaMystic changed the title feat(balance): Improve Obliterated trait feat: Improve Obliterated trait (balance) Jan 1, 2025
@KRdaMystic KRdaMystic added PR: Improvment Makes something better and removed PR: Fix This is a fix for a bug labels Jan 1, 2025
@OH296 OH296 merged commit 92d5d9c into Adeptus-Dominus:release/0.10.0.0 Jan 1, 2025
6 checks passed
@KRdaMystic KRdaMystic deleted the adj/obliterated branch January 2, 2025 05:39
@EttyKitty EttyKitty added the PR: Misc Change A change with no distinct category label Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Improvment Makes something better PR: Misc Change A change with no distinct category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants