fix: Forge assignment bugs

[OH296]

• general overhaul of FeatureSelected struct
• correct defualt options for .is_at_location
• correct tracking of techmarine forge assignments fixed

Summary by Sourcery

Fix forge assignment bugs and improve the FeatureSelected struct.

Bug Fixes:

• Correct default options for unit location checks.
• Correct tracking of Techmarine forge assignments.

Enhancements:

• Overhaul of the FeatureSelected struct to improve data handling.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request fixes several bugs related to forge assignments and other game mechanics. It refactors the FeatureSelected struct, corrects default options for the is_at_location function, and improves the tracking of Techmarine forge assignments.

File-Level Changes

Change	Details	Files
Refactored the FeatureSelected struct to improve data management and fix forge assignment bugs.	Added planet_data struct to store planet and system information. Used planet_data struct to access planet and system data consistently. Removed redundant planet_data initialization. Simplified forge assignment logic using planet_data. Updated feature selection to use the new FeatureSelected struct. Corrected forge data access in planet displays. Fixed forge assignment tracking in task selector.	scripts/scr_draw_planet_features/scr_draw_planet_features.gml objects/obj_star/Alarm_3.gml objects/obj_star_select/Draw_64.gml scripts/scr_manage_task_selector/scr_manage_task_selector.gml
Corrected default options for the is_at_location function to handle cases where no location is specified.	Updated is_at_location to accept optional location arguments. Fixed unit location checks to handle missing or invalid location data.	scripts/is_specialist/is_specialist.gml scripts/scr_check_equip/scr_check_equip.gml
Improved tracking of Techmarine forge assignments and fixed related bugs.	Corrected the logic for checking Techmarine assignments to forges. Fixed a bug where forge assignments were not being tracked correctly. Ensured that the correct number of Techmarines are assigned to each forge.	scripts/scr_draw_planet_features/scr_draw_planet_features.gml scripts/scr_manage_task_selector/scr_manage_task_selector.gml
Fixed a bug in the ranged damage calculation for units with no ranged weapons.	Corrected the condition for checking if a unit has ranged weapons.	scripts/scr_marine_struct/scr_marine_struct.gml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @OH296 - I've reviewed your changes and they look great!

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}