fix: Spawning bugs with outdated function name

[OH296]

• bug from outdated function name in scr_add_man
• occasionally stored unit.ship_location would go stale
  • will need to find better solution in future in theory scr_ship_clean should prevent this

Summary by Sourcery

Bug Fixes:

• Fixed a bug that caused marine location data to become stale.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request fixes a bug where the incorrect function name was used in scr_add_man, and implements a safeguard against stale ship locations in scr_marine_struct.

File-Level Changes

Change	Details	Files
Fix bug from outdated function name alter_unit_equipment	Replaced alter_unit_equipment with alter_equipment in scr_add_man to fix a bug caused by an outdated function name.	scripts/scr_add_man/scr_add_man.gml
Implement safeguard against stale ship locations	Added a conditional check to ensure location_id is within the bounds of obj_ini.ship_location before accessing it. If location_id is out of bounds, the location is retrieved from obj_ini.loc using company and marine_number as indices, preventing potential errors from stale data. This acts as a safeguard against stale ship locations, although a more robust solution may be needed in the future.	scripts/scr_marine_struct/scr_marine_struct.gml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @OH296 - I've reviewed your changes - here's some feedback:

Overall Comments:

• Please create a tracking issue for implementing a more robust ship location management system to prevent stale data, as mentioned in your PR description.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}