Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: boarder sprites and fleet sprites being wrong #358

Merged

Conversation

VanWeapon
Copy link
Contributor

@VanWeapon VanWeapon commented Dec 31, 2024

Description of changes

  • fixed indexing of image file naming

Reasons for changes

  • bugfix

Related links

Summary by Sourcery

Bug Fixes:

  • Correct the display of boarder and fleet sprites by adjusting the image indexing in scr_image calls.

Copy link
Contributor

sourcery-ai bot commented Dec 31, 2024

Reviewer's Guide by Sourcery

This pull request fixes a bug where the border sprites and fleet sprites were incorrect by changing the indexing of the image file naming. This specifically changes the index of the "ui/force" sprite in obj_p_ship/Draw_0.gml from 0 to 1.

File-Level Changes

Change Details Files
Fixed indexing of image file naming for border sprites
  • Changed the index of the scr_image function call for the "ui/force" sprite from 0 to 1 to correct the border sprite display
  • The change was made within the if (boarders>0) block, indicating it specifically targets the display of border sprites when present
objects/obj_p_ship/Draw_0.gml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions github-actions bot added the PR: Sprites Changes to sprites/images label Dec 31, 2024
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @VanWeapon - I've reviewed your changes - here's some feedback:

Overall Comments:

  • PR title should follow the conventional commit format referenced in the template (e.g. 'fix: incorrect sprite indices for boarders and fleet')
  • Please provide more detailed description of what visual issues this fixes. Before/after screenshots would be helpful.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@VanWeapon VanWeapon changed the title Fix: boarder sprites and fleet sprites being wrong fix: boarder sprites and fleet sprites being wrong Dec 31, 2024
@VanWeapon VanWeapon self-assigned this Dec 31, 2024
@EttyKitty EttyKitty added the PR: Fix This is a fix for a bug label Dec 31, 2024
@EttyKitty EttyKitty merged commit fea4e83 into Adeptus-Dominus:release/0.10.0.0 Dec 31, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Fix This is a fix for a bug PR: Sprites Changes to sprites/images
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants