Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Tartaros face plate and and helm variants #354

Merged
merged 14 commits into from
Dec 29, 2024

Conversation

OH296
Copy link
Collaborator

@OH296 OH296 commented Dec 29, 2024

Summary by Sourcery

New Features:

  • Added Tartaros faceplate, helm, and trim variants.

Copy link
Contributor

sourcery-ai bot commented Dec 29, 2024

Reviewer's Guide by Sourcery

This pull request introduces new Tartaros armour variants for the faceplate, chest, and gorget. It adds new sprites for the faceplate, head, left trim, and right trim. It also updates the spr_tartaros_chest, spr_tartaros_gorget, spr_tartaros_right_leg, and spr_tartaros_left_leg sprites with additional frames and bounding box adjustments. Finally, it updates the get_complex_set function in scr_draw_unit_image to include the new Tartaros armour variants.

File-Level Changes

Change Details Files
Added Tartaros armour variants for the faceplate, chest, and gorget.
  • Added new sprites for the faceplate, head, left trim, and right trim.
  • Added new frames and adjusted bounding boxes for the chest, gorget, right leg, and left leg sprites.
  • Updated the get_complex_set function to include the new Tartaros armour variants.
sprites/spr_tartaros_chest/spr_tartaros_chest.yy
sprites/spr_tartaros_gorget/spr_tartaros_gorget.yy
sprites/spr_tartaros_right_leg/spr_tartaros_right_leg.yy
sprites/spr_tartaros_left_leg/spr_tartaros_left_leg.yy
scripts/scr_draw_unit_image/scr_draw_unit_image.gml
sprites/spr_tartaros_complex/spr_tartaros_complex.yy
sprites/spr_tartaros_left_trim/spr_tartaros_left_trim.yy
sprites/spr_tartaros_right_trim/spr_tartaros_right_trim.yy
sprites/spr_tartaros_head/spr_tartaros_head.yy
sprites/spr_tartaros_faceplate/spr_tartaros_faceplate.yy

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions github-actions bot added PR: Sprites Changes to sprites/images PR: Feature Adds something new PR: Major Coding Big enough to possibly clash with other PRs labels Dec 29, 2024
sourcery-ai[bot]
sourcery-ai bot previously approved these changes Dec 29, 2024
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @OH296 - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@OH296
Copy link
Collaborator Author

OH296 commented Dec 29, 2024

@sourcery-ai review

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @OH296 - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@OH296 OH296 merged commit 89b68b7 into Adeptus-Dominus:release/0.10.0.0 Dec 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Feature Adds something new PR: Major Coding Big enough to possibly clash with other PRs PR: Sprites Changes to sprites/images
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants