Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adjust founding chapter trait values #353

Merged

Conversation

KRdaMystic
Copy link
Contributor

@KRdaMystic KRdaMystic commented Dec 29, 2024

Description of changes

  • Adjusts founding chapter trait values

Reasons for changes

  • Old values resulted in negative effects

Summary by Sourcery

Enhancements:

  • Updated trait values for several founding chapters.

changes bonus distribution for founding chapters.
Copy link
Contributor

sourcery-ai bot commented Dec 29, 2024

Reviewer's Guide by Sourcery

This PR adjusts the founding chapter trait values to address negative effects caused by the previous values. The core change is replacing the previous minimum-based values with fixed values, ensuring more balanced and predictable outcomes.

File-Level Changes

Change Details Files
Updated trait values for several founding chapters
  • Changed intelligence trait for Students of War from [0, 1, "min"] to [1, 1]
  • Changed weapon_skill trait for Secretive Knights from [0, 1, "min"] to [1, 1]
  • Changed wisdom trait for Warriors of the Wind from [0, 1, "min"] to [1, 1]
  • Changed wisdom trait for Wolf Prince from [0, 1, "min"] to [1, 1]
  • Changed wisdom trait for Shadow Masters from [0, 1] to [1, 1]
  • Changed technology trait for Keepers of the Flame from [0, 1, "min"] to [1, 1]
  • Changed strength trait for Will of Iron from [0, 1, "min"] to [1, 1]
  • Changed weapon_skill trait for Host of Angels from [0, 1, "min"] to [1, 1]
  • Changed ballistic_skill trait for Obstinate Defenders from [0, 1, "min"] to [1, 1]
scripts/scr_unit_traits/scr_unit_traits.gml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions github-actions bot added the PR: Refactor Rewriting/restructuring code, while keeping general behaviour label Dec 29, 2024
@sourcery-ai sourcery-ai bot changed the title refactor: Adjust founding traits @sourcery-ai fix: Adjust founding chapter trait values Dec 29, 2024
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @KRdaMystic - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@OH296 OH296 merged commit 120fc43 into Adeptus-Dominus:release/0.10.0.0 Dec 29, 2024
4 checks passed
@KRdaMystic KRdaMystic deleted the adjustments/trait_bonus_adj branch December 30, 2024 07:00
@EttyKitty EttyKitty added PR: Fix This is a fix for a bug and removed PR: Refactor Rewriting/restructuring code, while keeping general behaviour labels Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Fix This is a fix for a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants