fix: Captains and CM not healing (loop from 1)

[EttyKitty]

Description of changes

• Changed the loop to start at 0. The loop was starting at 1, the captains and chapter master sit at 0.

Reasons for changes

• To fix a bug.

Related links

• https://discord.com/channels/714022226810372107/1272865272159535114/1322703457052004373

Summary by Sourcery

Bug Fixes:

• Fix an issue where Captains and Combat Medics were not receiving healing.

[sourcery-ai]

Reviewer's Guide by Sourcery

This PR fixes a bug where Captains and CM were not being healed by the Apothecary. The bug was caused by the loop starting at index 1 instead of 0. The fix changes the loop start index to 0, ensuring all units are checked and potentially healed.

File-Level Changes

Change	Details	Files
Fix loop start index	Changed the loop start index from 1 to 0 in the apothecary_simple function to include all units in the healing check.	scripts/scr_apothecary_ground/scr_apothecary_ground.gml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @EttyKitty - I've reviewed your changes - here's some feedback:

Overall Comments:

• Please expand the PR description to explain that this fixes an off-by-one error where units at index 0 (typically company officers) were being skipped in the healing loop.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}