-
Notifications
You must be signed in to change notification settings - Fork 32
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
PR: Player can define extra vehicles in custom chapter json (#362)
<!--- PR title format should be `commit type: Title` --> <!--- Commit types can be found at https://github.com/pvdlg/conventional-commit-types?tab=readme-ov-file#commit-types --> <!--- You can add `@sourcery-ai` into the title, so that the bot auto-generates a title --> ## Description of changes <!--- Leverage the list functionality, if you have many changes --> - implements the `extra_vehicles` attribute from chapter jsons which works on init now. All extra vehicles are added to the 10th company so they show up on the homeworld at the beginning of the game ## Reasons for changes <!--- Leverage the list functionality, here as well --> - implement unfinished feature ## Related links <!--- Other PRs; Discord bug reports, messages, threads, etc.; outside docs, etc.; --> - https://discord.com/channels/714022226810372107/714027491412410369/1323805664723734549 ## Summary by Sourcery New Features: - Added support for the "extra_vehicles" attribute in chapter JSON files to add vehicles to the 10th company during game initialization.
- Loading branch information
Showing
4 changed files
with
76 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -193,7 +193,6 @@ | |
"ninth": 0, | ||
"tenth": 0 | ||
}, | ||
// * Not working yet | ||
"extra_vehicles": { | ||
"rhino": 0, | ||
"whirlwind": 0, | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters