fix: make urls relative before calling Sbrowse #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Now you can use the `Slog` command with no arguments and it will use the rev `bottom:top` to focus the log to your current stack. Test Plan: CI, unit tests.
Summary: When you are in a buffer that has a absolute path as its name. When calling Sbrowse it will use that hole path in the url. This is obviously incorrect. Now we are making sure we get the relative path before we create the url so we don't end up going to a 404. Test Plan: CI, unit tests. I have also had the change locally for quite some time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
When you are in a buffer that has a absolute path as its name. When calling
Sbrowse it will use that hole path in the url. This is obviously incorrect.
Now we are making sure we get the relative path before we create the url so we
don't end up going to a 404.
Test Plan:
CI, unit tests. I have also had the change locally for quite some time.
Stack created with Sapling. Best reviewed with ReviewStack.