Merge pull request #121 from AddSearch/fix-handling-of-commas-in-get-…

…parameters Fix reading and writing unrelated GET parameters to history and docum…
AddSearch · Aug 13, 2024 · bc40fc7 · bc40fc7
2 parents 0310a2f + 6e09ef3
commit bc40fc7
Show file tree

Hide file tree

Showing 7 changed files with 11 additions and 11 deletions.
diff --git a/README.md b/README.md
@@ -14,8 +14,8 @@ effortlessly.
 ```html
 <!-- Libraries -->
 <script src="https://cdn.jsdelivr.net/npm/addsearch-js-client@0.8/dist/addsearch-js-client.min.js"></script>
-<script src="https://cdn.jsdelivr.net/npm/addsearch-search-ui@0.7/dist/addsearch-search-ui.min.js"></script>
-<link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/addsearch-search-ui@0.7/dist/addsearch-search-ui.min.css" />
+<script src="https://cdn.jsdelivr.net/npm/addsearch-search-ui@0.8/dist/addsearch-search-ui.min.js"></script>
+<link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/addsearch-search-ui@0.8/dist/addsearch-search-ui.min.css" />
 
 <!-- Containers for UI components-->
 <div id="searchfield-container"></div>

diff --git a/dist/addsearch-search-ui.min.css b/dist/addsearch-search-ui.min.css
diff --git a/dist/addsearch-search-ui.min.js b/dist/addsearch-search-ui.min.js
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "addsearch-search-ui",
-  "version": "0.8.10",
+  "version": "0.8.11",
   "description": "JavaScript library to develop Search UIs for the web",
   "main": "./dist/addsearch-search-ui.min.js",
   "jsdelivr": "./dist/addsearch-search-ui.min.js",

diff --git a/src/util/history.js b/src/util/history.js
@@ -214,7 +214,7 @@ export function queryParamsToObject(url) {
   const qsArrUsedInSearch = qsArr.filter(v => !qsArrUnrelated.includes(v));
 
   if (qsArrUnrelated.length) {
-    obj['addsearchUnrelatedParams'] = qsArrUnrelated.join(',');
+    obj['addsearchUnrelatedParams'] = qsArrUnrelated.join('&');
   }
 
   qsArrUsedInSearch.forEach(v => {
@@ -247,7 +247,7 @@ export function objectToQueryParams(obj) {
       }
       let value = '';
       if (key === 'addsearchUnrelatedParams') {
-        const unrelatedParams = obj[key].split(',');
+        const unrelatedParams = obj[key].split('&');
         qs = qs + unrelatedParams.join('&');
         continue;
       }

diff --git a/test/util/history.js b/test/util/history.js
@@ -53,7 +53,7 @@ describe('history', () => {
     it('return a bunch of query parameter', () => {
       const url = 'https://addsearch.com/test?search=b%C3%B6&search_page=3&foo=bar&foo=bar2';
       const expectedValue = {
-        addsearchUnrelatedParams: 'foo=bar,foo=bar2',
+        addsearchUnrelatedParams: 'foo=bar&foo=bar2',
         search: 'bö',
         search_page: '3',
       };