Merge pull request #125 from AddSearch/sc-10506/duplicated-library-sc…

…ript-load-breaks-search

[sc-10506] export Handlebars_runtime as module's prop instead of wind…

README.md

@@ -928,13 +928,15 @@ Or precompile the whole directory
 ```js
   handlebars your-dir/all-templates/> output-dir/all-precompiled-templates-srp.js -c handlebars/runtime
 ```
-`-c` flag creates a `require` statement for Handlebars-runtime in your precompiled template file. 
+`-c` flag creates a `require` statement for Handlebars-runtime in your precompiled template file. Please note that -c will build your templates into a CommonJS module, which is not supported in the browser.
+
 Use the precompiled template inside a component, for example:
 ```js
-  // Handlebars are exposed globally when loading Search UI Library
+  // Handlebars are exported within Search UI Library's module as Handlebars_runtime
   // You can also install handlebars runtime package and import it
   // Below code will use your precompiled template of the file name "searchfield.handlebars"
 
+  var Handlebars = AddSearchUI.Handlebars_runtime;
   var precompiledTemplates = Handlebars.templates;
   searchui.searchField({
     containerId: 'searchfield-container',

index.js

@@ -7,6 +7,4 @@ module.exports.LOAD_MORE_TYPE = require("./src/components/loadmore/index.js").LO
 module.exports.RECOMMENDATION_TYPE = require("./src/components/recommendations/index.js").RECOMMENDATION_TYPE;
 module.exports.RANGE_FACETS_TYPE = require("./src/components/rangefacets/index.js").RANGE_FACETS_TYPE;
 
-if (typeof window !== 'undefined' && typeof window.Handlebars === 'undefined') {
-  window.Handlebars = require('handlebars/runtime');
-}
+module.exports.Handlebars_runtime = require('handlebars/runtime');

package.json

@@ -1,6 +1,6 @@
 {
   "name": "addsearch-search-ui",
-  "version": "0.8.13",
+  "version": "0.8.14",
   "description": "JavaScript library to develop Search UIs for the web",
   "main": "./dist/addsearch-search-ui.min.js",
   "jsdelivr": "./dist/addsearch-search-ui.min.js",

src/util/handlebars.js

@@ -79,11 +79,9 @@ export function registerDefaultHelpers() {
 
 export function registerHelper(helperName, helperFunction) {
   handlebars.registerHelper(helperName, helperFunction);
-  const HandlebarsRunTime = (typeof window !== 'undefined' && window.Handlebars) ? window.Handlebars : HandlebarsRuntime;
-  HandlebarsRunTime.registerHelper(helperName, helperFunction);
+  HandlebarsRuntime.registerHelper(helperName, helperFunction);
 }
 export function registerPartial(partialName, partialTemplate) {
   handlebars.registerPartial(partialName, partialTemplate);
-  const HandlebarsRunTime = (typeof window !== 'undefined' && window.Handlebars) ? window.Handlebars : HandlebarsRuntime;
-  HandlebarsRunTime.registerPartial(partialName, partialTemplate);
+  HandlebarsRuntime.registerPartial(partialName, partialTemplate);
 }